LanguageConfig.current problems #1369

Closed
crucialfelix opened this Issue Mar 25, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@crucialfelix
Member

crucialfelix commented Mar 25, 2015

1: If there was no config file when booting up, then LanguageConfig.current returns ""

Which breaks Quarks because it is now saving to a config file of ""

If it instead returns nil (which would be the correct answer), then when Quarks calls LanguageConfig.store(nil); that will correctly create a default sclang_config.yaml and all will function as advertised.

fix: LanguageConfig.current should return nil

2: If a config file is created or selected using Preferences, then LanguageConfig.current still returns the old value. Even recompiling does not get the new value.

The value has been saved to sc_ide_conf.yaml

But only restarting SuperCollider IDE will load the new value.

fix: should parse the value directly from the yaml file

@crucialfelix

This comment has been minimized.

Show comment
Hide comment
@crucialfelix

crucialfelix Mar 25, 2015

Member

switching the config is messy. There is a confusion because config values are being read out of memory, but the settings are changing files on disk.

Member

crucialfelix commented Mar 25, 2015

switching the config is messy. There is a confusion because config values are being read out of memory, but the settings are changing files on disk.

@crucialfelix crucialfelix added this to the 3.7 milestone Mar 25, 2015

@crucialfelix crucialfelix self-assigned this Mar 25, 2015

@crucialfelix

This comment has been minimized.

Show comment
Hide comment
@crucialfelix

crucialfelix Mar 26, 2015

Member

Solution if somebody is having problems right now with 3.7-alpha-0 and not being able to install Quarks:

  1. go to the app preferences. create or select a config file
  2. restart SuperCollider
Member

crucialfelix commented Mar 26, 2015

Solution if somebody is having problems right now with 3.7-alpha-0 and not being able to install Quarks:

  1. go to the app preferences. create or select a config file
  2. restart SuperCollider
@scztt

This comment has been minimized.

Show comment
Hide comment
@scztt

scztt Mar 26, 2015

Contributor

When this gets resolved, it seems like a couple ppl should validate the full quarks workflow (i.e. install SC, checkout and install Quarks, recompile, uninstall - whatever you'd do if you've never used quarks before) on mac/linux, as well as a scenario when you're coming from 3.6.x with already-installed quarks... make sure there aren't any other lingering hiccups. And if that looks solid, this should definitely trigger an alpha1 build. All that's required for that is (a) adding a tag and pushing it to github (travis will build and post the release binary), (b) updating the release wiki page with build link + notes.

Contributor

scztt commented Mar 26, 2015

When this gets resolved, it seems like a couple ppl should validate the full quarks workflow (i.e. install SC, checkout and install Quarks, recompile, uninstall - whatever you'd do if you've never used quarks before) on mac/linux, as well as a scenario when you're coming from 3.6.x with already-installed quarks... make sure there aren't any other lingering hiccups. And if that looks solid, this should definitely trigger an alpha1 build. All that's required for that is (a) adding a tag and pushing it to github (travis will build and post the release binary), (b) updating the release wiki page with build link + notes.

@crucialfelix

This comment has been minimized.

Show comment
Hide comment
@crucialfelix

crucialfelix Mar 26, 2015

Member

yes, more than just me testing it !

I'll be even more thorough myself next time.
nobody thought about the config file problem before because it
auto-generates when you pass it nil

On Thu, Mar 26, 2015 at 7:46 PM scztt notifications@github.com wrote:

When this gets resolved, it seems like a couple ppl should validate the
full quarks workflow (i.e. install SC, checkout and install Quarks,
recompile, uninstall - whatever you'd do if you've never used quarks
before) on mac/linux, as well as a scenario when you're coming from 3.6.x
with already-installed quarks... make sure there aren't any other lingering
hiccups. And if that looks solid, this should definitely trigger an alpha1
build. All that's required for that is (a) adding a tag and pushing it to
github (travis will build and post the release binary), (b) updating the
release wiki page with build link + notes.


Reply to this email directly or view it on GitHub
#1369 (comment)
.

Member

crucialfelix commented Mar 26, 2015

yes, more than just me testing it !

I'll be even more thorough myself next time.
nobody thought about the config file problem before because it
auto-generates when you pass it nil

On Thu, Mar 26, 2015 at 7:46 PM scztt notifications@github.com wrote:

When this gets resolved, it seems like a couple ppl should validate the
full quarks workflow (i.e. install SC, checkout and install Quarks,
recompile, uninstall - whatever you'd do if you've never used quarks
before) on mac/linux, as well as a scenario when you're coming from 3.6.x
with already-installed quarks... make sure there aren't any other lingering
hiccups. And if that looks solid, this should definitely trigger an alpha1
build. All that's required for that is (a) adding a tag and pushing it to
github (travis will build and post the release binary), (b) updating the
release wiki page with build link + notes.


Reply to this email directly or view it on GitHub
#1369 (comment)
.

@crucialfelix

This comment has been minimized.

Show comment
Hide comment
@crucialfelix

crucialfelix Mar 27, 2015

Member

i'll do this tomorrow, didn't get a chance today.

Member

crucialfelix commented Mar 27, 2015

i'll do this tomorrow, didn't get a chance today.

telephon added a commit that referenced this issue Mar 29, 2015

Merge pull request #1388 from crucialfelix/topic/fix-language-config
fixes #1369 LanguageConfig.current returns "", should return nil
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment