fix-DiskOut #1382

Merged
merged 2 commits into from Apr 1, 2015

Conversation

Projects
None yet
3 participants
@muellmusik
Contributor

muellmusik commented Mar 28, 2015

This aims to fix a bug where DiskOut didn't always write the last chunk of samples. This should solve the problem discussed in Issue #1380 (although the default size should still be collected as suggested) and discussed on sc-dev in this thread: https://www.listarc.bham.ac.uk/lists/sc-dev/msg53886.html

It adds a Dtor which writes an extra msg to the DiskIO fifo if needed when the UGen is destroyed. There should be no API incompatibilities AFAICS.

plugins: Fix bug where DiskOut didn't always write the last chunk of …
…samples

- This adds a Dtor which writes an extra msg to the DiskIO fifo if needed when the UGen is destroyed

Signed-off-by: Scott Wilson <i@scottwilson.ca>
@Sciss

This comment has been minimized.

Show comment
Hide comment
@Sciss

Sciss Mar 29, 2015

Member

excellent, thanks!

Member

Sciss commented on 73f779e Mar 29, 2015

excellent, thanks!

classlib + help: Improve built-in Server recording
- make default buffer size sampleRate.nextPowerofTwo
- add ability to set the buffer size for built-in recording

Signed-off-by: Scott Wilson <i@scottwilson.ca>
@muellmusik

This comment has been minimized.

Show comment
Hide comment
@muellmusik

muellmusik Mar 31, 2015

Contributor

Merge?

Contributor

muellmusik commented Mar 31, 2015

Merge?

@danstowell

This comment has been minimized.

Show comment
Hide comment
@danstowell

danstowell Apr 1, 2015

Member

Not tested but optimistic :) looks good from reading

Member

danstowell commented Apr 1, 2015

Not tested but optimistic :) looks good from reading

muellmusik added a commit that referenced this pull request Apr 1, 2015

@muellmusik muellmusik merged commit 56e5f22 into master Apr 1, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@brianlheim brianlheim deleted the fix-DiskOut branch Jan 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment