New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCDoc: Escape single-quotes in generated javascript #3301

Merged
merged 2 commits into from Nov 20, 2017

Conversation

Projects
None yet
3 participants
@brianlheim
Copy link
Member

brianlheim commented Nov 18, 2017

Fixes issue #3298.

Tested on macOS 10.13 (not that OS should make a difference).

I am milestoning this as 3.9.1, but if people think it's safe it could go in 3.9.0. I would say that since the issue/workaround is known, it would be safer to wait for now.

@patrickdupuis patrickdupuis merged commit c2d5fcb into supercollider:3.9 Nov 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@brianlheim brianlheim deleted the brianlheim:issue/3298 branch Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment