Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCIDE] Fix duplicate icons in Gnome3 dock #3380

Merged
merged 2 commits into from Jan 16, 2018

Conversation

Projects
None yet
5 participants
@patrickdupuis
Copy link
Contributor

patrickdupuis commented Jan 3, 2018

On Gnome3, we get duplicate SC-IDE icons in the left-hand side "Favorites" dock. This only happens when SCIDE is pinned to the dock and then launched. I found the solution here:
https://askubuntu.com/questions/403766/duplicate-icons-for-manually-created-gnome-launcher-items

Basically, the .desktop file needs to have a field called StartupWMClass with the value scide. For more info, see https://standards.freedesktop.org/desktop-entry-spec/latest/ar01s06.html

This seems to also fix #2646 as a side-effect.

I also made a few additions and changes to the .desktop file based on what I read on the freedesktop.org site.

@patrickdupuis patrickdupuis added this to the 3.9.1 milestone Jan 3, 2018

@patrickdupuis patrickdupuis requested review from jamshark70 and snappizz Jan 3, 2018

@jamshark70

This comment has been minimized.

Copy link
Contributor

jamshark70 commented Jan 3, 2018

Ah, I appreciate that you remembered I was using gnome3, but I'm on Ubuntu Studio now, with xfce4 and I like it better ;) I could check later which gnome version is in the Ubuntu 16 repositories.

@patrickdupuis

This comment has been minimized.

Copy link
Contributor Author

patrickdupuis commented Jan 3, 2018

Good to know! Don't bother installing Gnome just for this. It's in the repos, but it's a major addition in terms of packages.

It would be nice to know in which menu categories the IDE ends up in with these changes. Should be in a Audio/Video related category, as well as Development/IDE type category.

@telephon
Copy link
Member

telephon left a comment

not a big thing, ignore if you like!

@@ -1,9 +1,11 @@
[Desktop Entry]
Name=SuperCollider IDE
GenericName=SuperCollider IDE
Comment=Audio synthesis and algorithmic musical creation

This comment has been minimized.

Copy link
@telephon

telephon Jan 3, 2018

Member

maybe better: "algorithmic music"

This comment has been minimized.

Copy link
@patrickdupuis

patrickdupuis Jan 3, 2018

Author Contributor

it was "musical composition" before, but I though that was too composition oriented. Simply "music" is better (it's too long as it is). What about "algorithmic sound"?

This comment has been minimized.

Copy link
@snappizz

snappizz Jan 3, 2018

Member

"Editor for the SuperCollider sound synthesis language"?

This comment has been minimized.

Copy link
@patrickdupuis

patrickdupuis Jan 3, 2018

Author Contributor

Duh... of course!

This comment has been minimized.

Copy link
@patrickdupuis

patrickdupuis Jan 3, 2018

Author Contributor

should it be audio or sound synthesis? also, is SC a just language or is it an environment or a framework? I'm never sure how to describe the project as a whole.

This comment has been minimized.

Copy link
@snappizz

snappizz Jan 3, 2018

Member

audio/sound are the same to me.

i tend to succinctly describe SC as "a sound synthesis platform." you can do "editor for the SuperCollider sound synthesis platform" if you want, but i chose the wording because the editor is specifically for editing sclang.

This comment has been minimized.

Copy link
@patrickdupuis

patrickdupuis Jan 3, 2018

Author Contributor

ok - going with "IDE for the SuperCollider audio synthesis language". I think we say "audio synthesis" more than "sound synthesis".

@patrickdupuis

This comment has been minimized.

Copy link
Contributor Author

patrickdupuis commented Jan 3, 2018

Last thing, 3.9.0 or 3.9.1? I'm fine either way.

@brianlheim

This comment has been minimized.

Copy link
Member

brianlheim commented Jan 3, 2018

I would say 3.9.1 please. We have a release candidate

The wording was corrected as suggested by @telephon and @snapppizz

@patrickdupuis patrickdupuis merged commit eedd4be into supercollider:3.9 Jan 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@patrickdupuis patrickdupuis deleted the patrickdupuis:topic/tinyIcon branch Jan 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.