New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scide: set default font backup to Monaco #3404

Merged
merged 1 commit into from Jan 16, 2018

Conversation

Projects
None yet
3 participants
@brianlheim
Member

brianlheim commented Jan 11, 2018

This fixes issue #2389 by adding a backup for the default IDE font. It
keeps the "monospace" family that currently works for Linux & Windows.
Monaco is the default font for macOS's terminal, so it's safe to assume
this will be installed for almost all users.

@brianlheim

This comment has been minimized.

Member

brianlheim commented Jan 11, 2018

I've tested this and it works as expected on macOS (10.13.2). The font substitutions are tried in-order, which means that for any other platform that made use of monospace (Linux and Windows), this has no effect.

@snappizz snappizz changed the base branch from develop to 3.9 Jan 14, 2018

@snappizz snappizz changed the base branch from 3.9 to develop Jan 14, 2018

@patrickdupuis

This comment has been minimized.

Contributor

patrickdupuis commented Jan 16, 2018

Shouldn't this be merged into 3.9? It will get into develop the next time 3.9 is merged into develop (in a week or so?).

@brianlheim brianlheim changed the base branch from develop to 3.9 Jan 16, 2018

@brianlheim brianlheim changed the base branch from 3.9 to develop Jan 16, 2018

scide: set default font backup to Monaco
This fixes issue #2389 by adding a backup for the default IDE font. It
keeps the "monospace" family that currently works for Linux & Windows.
Monaco is the default font for macOS's terminal, so it's safe to assume
this will be installed for almost all users.

@brianlheim brianlheim changed the base branch from develop to 3.9 Jan 16, 2018

@brianlheim

This comment has been minimized.

Member

brianlheim commented Jan 16, 2018

@patrickdupuis It was based on develop originally. I just rebased and force-pushed, should be OK to go after CI finishes

@patrickdupuis patrickdupuis merged commit 8567e7e into supercollider:3.9 Jan 16, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@brianlheim brianlheim deleted the brianlheim:issue/2389 branch Jan 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment