New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scide - theme: add dracula #3410

Merged
merged 2 commits into from Jan 23, 2018

Conversation

Projects
None yet
5 participants
@gusano
Copy link
Member

gusano commented Jan 12, 2018

Some screenshots:

deepinscreenshot_select-area_20180112182859
deepinscreenshot_select-area_20180112182534
deepinscreenshot_select-area_20180112182514

scide - theme: add dracula
Signed-off-by: Yvan Volochine <yvan.github@gmail.com>
@brianlheim

This comment has been minimized.

Copy link
Member

brianlheim commented Jan 12, 2018

wow, it looks very nice! @gusano are you sure using this theme doesn't require a license or attribution of some sort?

@gusano

This comment has been minimized.

Copy link
Member Author

gusano commented Jan 12, 2018

@brianlheim that's very much possible https://github.com/dracula/dracula-theme/blob/master/LICENSE
I'm not a license guru though.. I'd happily fix that if I'm told how

@brianlheim

This comment has been minimized.

Copy link
Member

brianlheim commented Jan 12, 2018

@gusano OK. Neither am I. I think it would be best to get in contact with them and ask how/if we should include the license text.

@patrickdupuis

This comment has been minimized.

Copy link
Contributor

patrickdupuis commented Jan 13, 2018

Trying this out. @gusano can you confirm the colour of the following text in the Post Window?

*** Welcome to SuperCollider 3.9.0-rc2. *** For help press Ctrl-D.

In your screenshots, it appears in white-ish. For me, it appears in black.

@snappizz

This comment has been minimized.

Copy link
Member

snappizz commented Jan 13, 2018

the MIT license is GPL-compatible, we are fine in copyrightland

@patrickdupuis

This comment has been minimized.

Copy link
Contributor

patrickdupuis commented Jan 13, 2018

I ❤️ this highlight colour
dracula

@patrickdupuis

This comment has been minimized.

Copy link
Contributor

patrickdupuis commented Jan 13, 2018

For sure MIT is fine, but how do we properly credit the authors? Do we need to include a license file somewhere?

@gusano

This comment has been minimized.

Copy link
Member Author

gusano commented Jan 13, 2018

@patrickdupuis yes it is white here (no custom theme in sc_ide_conf.yaml, dracula theme in scide).

About the license, I'd rather have themes as *.yaml files before including this (and Solarized ones) so our life is easier.

@Sciss

This comment has been minimized.

Copy link
Member

Sciss commented Jan 13, 2018

Looks nice. I'm sceptic that copyright applies to the use of a range of RGB values. http://www.colourlovers.com/faq/18/How_can_you_copyright_a_color_palette is quite vague about it, claiming that you could protect "the arrangement of those colors into the rectangular shape" only.

@brianlheim

This comment has been minimized.

Copy link
Member

brianlheim commented Jan 13, 2018

OK, yet the repository has a license, and we're copying the name here. I think it would be best to contact them just as a gesture of good faith.

@brianlheim

This comment has been minimized.

Copy link
Member

brianlheim commented Jan 13, 2018

(they may also want to know purely for the sake of adding it to their list of projects using it)

@snappizz snappizz added the env: SCIDE label Jan 14, 2018

@brianlheim

This comment has been minimized.

Copy link
Member

brianlheim commented Jan 16, 2018

About the license, I'd rather have themes as *.yaml files before including this (and Solarized ones) so our life is easier.

@gusano - I'm not sure what you mean by this. Would you still want this to be reviewed/merged as-is or should it be closed and an issue opened for yaml-format themes?

@gusano

This comment has been minimized.

Copy link
Member Author

gusano commented Jan 16, 2018

@brianlheim I already opened an issue for supporting yaml themes and I think it might take some time to be done.. Reviewing/merging this one is up to you :)

@snappizz
Copy link
Member

snappizz left a comment

i would recommend adding the Theme::fillDracula() function to a separate C++ file with a comment on top indicating the full license.

@patrickdupuis

This comment has been minimized.

Copy link
Contributor

patrickdupuis commented Jan 22, 2018

As was discussed on slack, adding this and other themes via separate C++ files requires a little more work than expected. It was decided to simply add the license text above the function that contains the theme's colour palette.

@patrickdupuis patrickdupuis merged commit f297f16 into develop Jan 23, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@patrickdupuis patrickdupuis deleted the topic/dracula-theme branch Jan 23, 2018

brianlheim added a commit to brianlheim/supercollider that referenced this pull request Jan 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment