New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supernova: load plugins from correct directories #3433

Merged
merged 1 commit into from Jan 17, 2018

Conversation

Projects
None yet
3 participants
@brianlheim
Member

brianlheim commented Jan 16, 2018

previously, plugins were loaded from /plugins within extension directories

Fixes #3391

Thanks to @florian-grond for the patch!

supernova: load plugins from correct directories
previously, plugins were loaded from /plugins within extension directories

Fixes #3391

@brianlheim brianlheim added this to the 3.9.1 milestone Jan 16, 2018

@florian-grond

This comment has been minimized.

florian-grond commented Jan 16, 2018

@florian-grond

That's the way to fix it, we tested it on OSX on two machines (for 3.9 and also the slightly different looking code for 3.8)

dyfer added a commit to dyfer/example-plugins that referenced this pull request Jan 16, 2018

Update README.md
I had mixed feelings in the first place when I included the description of the issue with plugins for supernova on osx in the general README.
Now this seems to be on its way to get fixed (see supercollider/supercollider#3433) so I think the README should not mention this soon-to-be-not-existing issue.

dyfer added a commit to dyfer/example-plugins that referenced this pull request Jan 16, 2018

Update README.md
I had mixed feelings in the first place when I included the description of the issue with plugins for supernova on osx in the general README.
Now this seems to be on its way to get fixed (see supercollider/supercollider#3433) so I think the README should not mention this soon-to-be-not-existing issue.

@dyfer dyfer referenced this pull request Jan 16, 2018

Merged

Update README.md #5

@patrickdupuis patrickdupuis merged commit 31ab4bf into supercollider:3.9 Jan 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@brianlheim brianlheim deleted the brianlheim:issue/3391 branch Jan 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment