New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sclang: create default compilation directories automatically #3469

Merged
merged 3 commits into from Jan 29, 2018

Conversation

Projects
None yet
4 participants
@brianlheim
Member

brianlheim commented Jan 25, 2018

Fixes #3468.
During library compilation, try to create any missing default directories

And, don't warn if these don't exist or can't be created

Solves much user confusion and annoyance

Also added some doc comments

brianlheim added some commits Jan 25, 2018

sclang: add accessor function
SC_LanguageConfig::defaultClassLibraryDirectories()
sclang: fix #3468
During library compilation, try to create any missing default directories

And, don't warn if these don't exist or can't be created

Solves much user confusion and annoyance

@brianlheim brianlheim added this to the 3.7.x milestone Jan 25, 2018

@brianlheim brianlheim modified the milestones: 3.7.x, 3.9.1 Jan 25, 2018

@snappizz snappizz modified the milestones: 3.9.1, 3.9.x Jan 25, 2018

@brianlheim

This comment has been minimized.

Member

brianlheim commented Jan 25, 2018

Tested locally (macOS 10.13.2).

System app support dir: sclang can't create Extensions, but it doesn't issue a warning. When I run sclang as root, it creates the directory.

User app support dir: sclang creates Extensions if I don't have it, and doesn't issue a warning.

@snappizz snappizz modified the milestones: 3.9.x, 3.9.1 Jan 25, 2018

@patrickdupuis

This comment has been minimized.

Contributor

patrickdupuis commented Jan 26, 2018

Looks good. Thanks for this @brianlheim!

I can't seem to run sclang as root. The user Extensions directory is created if not present. No warnings if either the system's or user's Extensions folder is not present.

@patrickdupuis

Works on Linux at least.

@brianlheim

This comment has been minimized.

Member

brianlheim commented Jan 26, 2018

Just gave it a try on Windows and it works there as well.

@brianlheim

This comment has been minimized.

Member

brianlheim commented Jan 26, 2018

I'm not going to merge this myself, would like at least one more set of eyes on this. Happy to answer any questions.

@brianlheim

This comment has been minimized.

Member

brianlheim commented Jan 29, 2018

ping

@telephon telephon merged commit 774c809 into supercollider:3.9 Jan 29, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@brianlheim brianlheim deleted the brianlheim:issue/3468 branch Jan 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment