Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class library: event - fix group in grain event #3483

Merged
merged 4 commits into from Feb 3, 2018

Conversation

Projects
None yet
5 participants
@telephon
Copy link
Member

telephon commented Jan 29, 2018

Fixes: #3481.

Quick test:

(type:\grain).play;

g = Group(s);

(type:\grain, group: g).play;
class library: event - fix group in grain event
We need to either call `asControlInput` or `value` to get the group,
because by default it is a function. `asControlInput` is more general,
it will also work for Group objects.
@brianlheim

This comment has been minimized.

Copy link
Member

brianlheim commented Jan 29, 2018

Thanks! Can you please add a unit test for this? (Not familiar with this code so apologies in advance if that's asking a lot)

@telephon

This comment has been minimized.

Copy link
Member Author

telephon commented Jan 29, 2018

ok, I'll do that.

@snappizz snappizz added this to the 3.9.1 milestone Jan 29, 2018

@snappizz

This comment has been minimized.

Copy link
Member

snappizz commented Jan 29, 2018

this is ✔️ for 3.9.1

@jamshark70

This comment has been minimized.

Copy link
Contributor

jamshark70 commented Jan 29, 2018

We should fix all affected event types in the main class library (from #3481: "This is a bug now in many of the event types").

We get bugs like this by making a global change and testing only one case. We keep bugs like this by fixing them on a case-by-case basis.

@jamshark70

This comment has been minimized.

Copy link
Contributor

jamshark70 commented Jan 30, 2018

Ok, I did a quick sweep of Event.sc and EventTypesWithCleanup.sc and it seems \grain was the only one missing the conversion. So I think this is good to go. Thanks, Julian!

@telephon

This comment has been minimized.

Copy link
Member Author

telephon commented Jan 30, 2018

I'll write a test that covers a little more than this case.

telephon added some commits Jan 30, 2018

test: refactor event tests
Event tests should point to the server’s defaults.
@patrickdupuis
Copy link
Contributor

patrickdupuis left a comment

Builds on Linux. Test passed all runs.

@@ -102,7 +102,98 @@ TestEvent : UnitTest {

}

test_server_messages {
test_server_message_head_type_grain {
this.assertEqualServerMessage(\grain, [ 9, \default, -1, 0, this.defaultGroupID])

This comment has been minimized.

Copy link
@snappizz

snappizz Feb 1, 2018

Member

whitespace: don't put spaces after [ or before ], use exactly one space after ,

This comment has been minimized.

Copy link
@telephon

telephon Feb 3, 2018

Author Member

I didn't put them there personally, but I can remove them ;)





This comment has been minimized.

Copy link
@snappizz

snappizz Feb 1, 2018

Member

too many blank lines

@snappizz snappizz modified the milestones: 3.9.1, 3.9.2 Feb 3, 2018

@snappizz snappizz merged commit 2cee904 into supercollider:3.9 Feb 3, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.