New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off-by-one error in posted warning message #3487

Merged
merged 2 commits into from Feb 2, 2018

Conversation

Projects
None yet
3 participants
@patrickdupuis
Copy link
Contributor

patrickdupuis commented Feb 2, 2018

This fixes #3485. I've also remove the colon (in failstr) that appeared before the clientID number in the warning text.

@patrickdupuis patrickdupuis added this to the 3.9.2 milestone Feb 2, 2018

@brianlheim

This comment has been minimized.

Copy link
Member

brianlheim commented Feb 2, 2018

Thanks!

@adcxyz adcxyz merged commit 93d7250 into supercollider:develop Feb 2, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@patrickdupuis patrickdupuis deleted the patrickdupuis:topic/offByOne branch Feb 2, 2018

@patrickdupuis

This comment has been minimized.

Copy link
Contributor

patrickdupuis commented Feb 2, 2018

This will need to be cherry picked into 3.9 I'm guessing? @snappizz

patrickdupuis added a commit that referenced this pull request Feb 3, 2018

Merge pull request #3488 from brianlheim/3487
Cherry-picking #3487 onto 3.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment