New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake: quote commands given to cmd (windows) #3525

Merged
merged 1 commit into from Mar 1, 2018

Conversation

Projects
None yet
3 participants
@brianlheim
Copy link
Member

brianlheim commented Feb 18, 2018

See https://stackoverflow.com/questions/4749155/passing-quotes-in-quotes-to-cmd-exe

The whole command needs to be wrapped in quotes in order for cmd to take quotes around paths

This makes it possible to build on windows with a source path containing spaces.

Cmake: quote commands given to cmd (windows)
See https://stackoverflow.com/questions/4749155/passing-quotes-in-quotes-to-cmd-exe

The whole command needs to be wrapped in quotes in order for cmd to take quotes around paths
@brianlheim

This comment has been minimized.

Copy link
Member

brianlheim commented Mar 1, 2018

This is tested and works fine, can someone please give it a quick look?

@joshpar joshpar self-assigned this Mar 1, 2018

@joshpar

joshpar approved these changes Mar 1, 2018

@patrickdupuis patrickdupuis merged commit b47f8de into supercollider:3.9 Mar 1, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@brianlheim brianlheim deleted the brianlheim:topic/win-space branch May 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment