New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Warp1 UGen example and some code cosmetics #3526

Merged
merged 2 commits into from Feb 20, 2018

Conversation

Projects
None yet
3 participants
@telephon
Copy link
Member

telephon commented Feb 18, 2018

No description provided.

telephon added some commits Feb 15, 2018

help: improve Warp1 example
This strips away some boilerplate code and concentrates on the ugen
itself. Also keeping it running makes it easier to experiment with.
@joshpar
Copy link
Member

joshpar left a comment

These are all fine with me.

@joshpar
Copy link
Member

joshpar left a comment

are we moving away from SynthDef in examples? I'm fine if we are, that would be my only concern here.

@telephon

This comment has been minimized.

Copy link
Member

telephon commented Feb 18, 2018

I find SynthDefs often a bit distracting from the main point. But I wouldn't try to remove them everywhere!

@patrickdupuis
Copy link
Contributor

patrickdupuis left a comment

I gave the class file changes a good look over. Ideally, these fixes would have been done in 2 seperate PRs for easier review.

@patrickdupuis patrickdupuis added this to the 3.9.2 milestone Feb 19, 2018

@telephon telephon merged commit 691c179 into supercollider:develop Feb 20, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

miguel-negrao added a commit to miguel-negrao/supercollider that referenced this pull request Mar 2, 2018

Merge pull request supercollider#3526 from telephon/topic-warp1-example
Improve Warp1 UGen example and some code cosmetics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment