New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic fix as score offset expansion #3544

Merged
merged 4 commits into from Mar 4, 2018

Conversation

Projects
None yet
4 participants
@telephon
Copy link
Member

telephon commented Feb 28, 2018

No description provided.

telephon added some commits Feb 28, 2018

class library: score expands timing
Now the score function correctly expands the timing values that the
usual play function expands. This fixes #3543
@snappizz

This comment has been minimized.

Copy link
Member

snappizz commented Feb 28, 2018

what issue does this fix? thanks.

@brianlheim

This comment has been minimized.

Copy link
Member

brianlheim commented Feb 28, 2018

Fixes #3543

var events, score, onsetTimes;
events = [(x: 0, lag: 0.5), (x: 1, dur: 0.5), (x: 2, lag: 0.5)];
score = Pseq(events).asScore(3);
onsetTimes = score.score.drop(1).postcs.select { |x| x[2] == \default }.collect { |x| x.first };

This comment has been minimized.

@brianlheim

brianlheim Mar 1, 2018

Member

can you please remove the postcs from these tests?

This comment has been minimized.

@brianlheim

brianlheim Mar 1, 2018

Member

also, using collect(_.first) at the end might make it more readable. personally i think it would be clearest to break this into two lines with an extra variable

This comment has been minimized.

@telephon

telephon Mar 1, 2018

Member

ok, done!

@joshpar

joshpar approved these changes Mar 4, 2018

@joshpar

joshpar approved these changes Mar 4, 2018

@joshpar

joshpar approved these changes Mar 4, 2018

@brianlheim brianlheim merged commit bce4abd into supercollider:3.9 Mar 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment