New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sclang: create config dir on startup, report errors from LanguageConfig.store #3577

Merged
merged 3 commits into from Mar 15, 2018

Conversation

Projects
None yet
3 participants
@brianlheim
Copy link
Member

brianlheim commented Mar 15, 2018

Fixes #2919.

  • Create the language config dir on startup. This step is skipped if run in standalone mode or a non-standard config file is specified with -l. This addresses issues raised by @jamshark70.
  • Modify SC_LanguageConfig::writeLibraryConfigYAMLFile (C++) to return false if writing fails
  • Modify LanguageConfig.store (SC) to throw a descriptive error on failure

Open to discussing alternate approaches. This doesn't feel perfect to me but I can't really put my finger on why. Either way, tested on macOS and works fine.

@telephon telephon merged commit 8a184fa into supercollider:3.9 Mar 15, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@brianlheim brianlheim deleted the brianlheim:issue/2919 branch Mar 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment