New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic/unit test info #4028

Merged
merged 5 commits into from Sep 9, 2018

Conversation

Projects
None yet
5 participants
@muellmusik
Contributor

muellmusik commented Aug 28, 2018

Purpose and Motivation

Add info on test expectations and links to info on unit test best practice

Types of changes

  • Documentation (non-code change which corrects or adds documentation for existing features)

Checklist

  • All tests are passing
  • If necessary, new tests were created to address changes in PR, and tests are passing
  • Updated documentation, if necessary
  • This PR is ready for review

muellmusik added some commits Aug 28, 2018

@muellmusik muellmusik requested a review from brianlheim Aug 28, 2018

@snappizz snappizz added the comp: help label Aug 28, 2018

@snappizz snappizz added this to the 3.11 milestone Aug 28, 2018

muellmusik added some commits Aug 29, 2018

@muellmusik

This comment has been minimized.

Show comment
Hide comment
@muellmusik

muellmusik Sep 1, 2018

Contributor

I’m not sure why Travis should have failed...

Contributor

muellmusik commented Sep 1, 2018

I’m not sure why Travis should have failed...

@muellmusik

This comment has been minimized.

Show comment
Hide comment
@muellmusik

muellmusik Sep 1, 2018

Contributor

Looks like unit tests

Contributor

muellmusik commented Sep 1, 2018

Looks like unit tests

@brianlheim

This comment has been minimized.

Show comment
Hide comment
@brianlheim

brianlheim Sep 1, 2018

Member

@muellmusik you have the ability to restart CI builds - login to Travis and AppVeyor with your github credentials (choose "SuperCollider" account in AppVeyor)

Member

brianlheim commented Sep 1, 2018

@muellmusik you have the ability to restart CI builds - login to Travis and AppVeyor with your github credentials (choose "SuperCollider" account in AppVeyor)

@muellmusik

This comment has been minimized.

Show comment
Hide comment
@muellmusik

muellmusik Sep 1, 2018

Contributor

@brianlheim done in travis; can't see where to restart in AppVeyor. I was more wondering why a commit to an md file should cause builds to fail

Contributor

muellmusik commented Sep 1, 2018

@brianlheim done in travis; can't see where to restart in AppVeyor. I was more wondering why a commit to an md file should cause builds to fail

@brianlheim

This comment has been minimized.

Show comment
Hide comment
@brianlheim

brianlheim Sep 1, 2018

Member

Simple version of the answer - because our CI script sometimes fails for no good reason. Something to do with buffering.

Re AppVeyor if you follow the link from the failing build here and are signed into the supercollider acct you will see a "rebuild commit" button. Easy way to check kf you're signed into the right acct is by going to Projects and you should see sc and sc3 plugins as the projects available.

Member

brianlheim commented Sep 1, 2018

Simple version of the answer - because our CI script sometimes fails for no good reason. Something to do with buffering.

Re AppVeyor if you follow the link from the failing build here and are signed into the supercollider acct you will see a "rebuild commit" button. Easy way to check kf you're signed into the right acct is by going to Projects and you should see sc and sc3 plugins as the projects available.

@muellmusik

This comment has been minimized.

Show comment
Hide comment
@muellmusik

muellmusik Sep 1, 2018

Contributor

Re AppVeyor if you follow the link from the failing build here and are signed into the supercollider acct you will see a "rebuild commit" button. Easy way to check kf you're signed into the right acct is by going to Projects and you should see sc and sc3 plugins as the projects available.

I can see those, but can't see the rebuild button. Anyway, it's irrelevant for this PR, oder?

Contributor

muellmusik commented Sep 1, 2018

Re AppVeyor if you follow the link from the failing build here and are signed into the supercollider acct you will see a "rebuild commit" button. Easy way to check kf you're signed into the right acct is by going to Projects and you should see sc and sc3 plugins as the projects available.

I can see those, but can't see the rebuild button. Anyway, it's irrelevant for this PR, oder?

@muellmusik

This comment has been minimized.

Show comment
Hide comment
@muellmusik

muellmusik Sep 2, 2018

Contributor

@brianlheim I tried again on my phone. Can see the projects, but not the rebuild button. It also says I can log in as you, which doesn’t seem right.

Contributor

muellmusik commented Sep 2, 2018

@brianlheim I tried again on my phone. Can see the projects, but not the rebuild button. It also says I can log in as you, which doesn’t seem right.

@muellmusik

This comment has been minimized.

Show comment
Hide comment
@muellmusik

muellmusik Sep 7, 2018

Contributor

This is still failing on the Qt5.9 App Store build, but none of the changes touches compilable code, so I think it’s irrelevant. Is it possible to finish review and merge?

Contributor

muellmusik commented Sep 7, 2018

This is still failing on the Qt5.9 App Store build, but none of the changes touches compilable code, so I think it’s irrelevant. Is it possible to finish review and merge?

@brianlheim

This comment has been minimized.

Show comment
Hide comment
@brianlheim

brianlheim Sep 9, 2018

Member

Yes, it's fine, the failure is just due to an old version of the appveyor script on your feature branch. Sorry that that noise was all over this PR. Also wanted to note that Core Team group members are definitely now able to restart AppVeyor builds; I had missed a checkbox within Appveyor's web UI. :) Thanks for your patience everyone!

Member

brianlheim commented Sep 9, 2018

Yes, it's fine, the failure is just due to an old version of the appveyor script on your feature branch. Sorry that that noise was all over this PR. Also wanted to note that Core Team group members are definitely now able to restart AppVeyor builds; I had missed a checkbox within Appveyor's web UI. :) Thanks for your patience everyone!

@brianlheim brianlheim merged commit a37645f into develop Sep 9, 2018

3 of 4 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@brianlheim brianlheim deleted the topic/UnitTestInfo branch Sep 9, 2018

@brianlheim brianlheim removed their request for review Sep 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment