New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tour of UGens GrainSin examples #4057

Merged
merged 1 commit into from Sep 12, 2018

Conversation

4 participants
@muellmusik
Contributor

muellmusik commented Sep 12, 2018

At some point an additional arg was added to GrainSin, but the Tour examples were not updated.

Purpose and Motivation

Make examples actually work

Types of changes

  • Documentation (non-code change which corrects or adds documentation for existing features)

Checklist

  • Updated documentation
  • This PR is ready for review
Fix Tour of UGens GrainSin examples
At some point an additional arg was added to GrainSin, but the Tour examples were not updated.

@snappizz snappizz added this to the 3.10 milestone Sep 12, 2018

@snappizz snappizz added the comp: help label Sep 12, 2018

@brianlheim brianlheim merged commit 78092d1 into develop Sep 12, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@brianlheim

This comment has been minimized.

Show comment
Hide comment
@brianlheim

brianlheim Sep 12, 2018

Member

Thanks!

Member

brianlheim commented Sep 12, 2018

Thanks!

@brianlheim brianlheim deleted the topic/fix-ugen-tour-grainsin-examples branch Sep 12, 2018

@patrickdupuis patrickdupuis added this to CHERRY PICK THESE in 3.10 Sep 18, 2018

brianlheim added a commit that referenced this pull request Sep 19, 2018

@patrickdupuis patrickdupuis moved this from CHERRY PICK THESE to Cherry-picked in 3.10 Sep 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment