sclang: fix string/symbol lexing #4255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #3352; previously would cause bad behavior with escaped double quotes inside strings and escaped single quotes inside symbols.
|
Wait for after 3.10.1 to merge |
mossheim
added
the
comp: sclang
nhthn
approved these changes
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
fixes #3352; previously would cause bad behavior with escaped double quotes
inside strings and escaped single quotes inside symbols.
what is essentially happening is that there are two separate lexing
routines - one that lexes individual tokens, and one that performs a
fast look-ahead to find a closing bracket. this bug is in the latter.
when lexing a line like:
"\"".csthe lookahead lexer routine starts at the first double quote, then
considers the second double quote (the escaped one) to be the end of the
string. then the third double quote is considered the opening of a new
string. however, the normal lexing routine doesn't have this bug, so it
can still succeed.
Types of changes
Checklist
the regression test suite I wrote but it's not exhaustive, so probably
beta testing is the best way to get this tested.
Remaining Work