QtCollider: QEnvelopeView - added get propertyfor selected indexes #674

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants
Member

blacksound commented Dec 2, 2012

Added the possibility to get the selected indexes for a QEnvelopeView. Not really sure about the return type here, but it works for me. Could you please have a look if this is okay?
This is my first pull request so please let me know if I'm doing anything wrong.

Member

blacksound commented Dec 3, 2012

I agree with you on the method name. I'l change my branch.
Btw. just curious here, is returning a VariantList the right way to go when returning arrays?

Owner

jleben commented Dec 3, 2012

Btw. just curious here, is returning a VariantList the right way to go when returning arrays?

Yes.

Member

blacksound commented Dec 3, 2012

I'll only change the declared property that is exposed to sclang. I'll keep the internal method names selectionIndexes() in order not to confuse with private _selection struct.
Sounds okay?

Owner

jleben commented Dec 3, 2012

I'll only change the declared property that is exposed to sclang. I'll keep the internal method names selectionIndexes() in order not to confuse with private _selection struct.
Sounds okay?

Sounds good. I'll test the branch soon...

Owner

jleben commented Dec 3, 2012

Erm... the point was to change the SC method name, not the Qt property name.

Otherwise looks and works ok.

Member

blacksound commented Dec 3, 2012

Ok. Fixed in my branch. class def now defines 'selection' and returns selectionIndexes property from qt widget.

Owner

jleben commented Dec 4, 2012

I squashed the commits into one, cleaned trailing whitespace, improved commit message, and pushed to master.
Next time, please take care of trailing whitespace.

Thanks a lot for contribution!

jleben closed this Dec 4, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment