ports supercollider to OpenBSD #683

Merged
merged 2 commits into from Dec 10, 2012

Conversation

Projects
None yet
3 participants
@acamari

acamari commented Dec 10, 2012

I'm working on porting supercollider to OpenBSD:

  • Adds preprocessor directives, backride on FreeBSD ones.
  • Adds SC_LID cmake option to enable/disable Linux Input Device support (not present on OpenBSD)

@acamari acamari closed this Dec 10, 2012

@acamari acamari reopened this Dec 10, 2012

@sensestage

This comment has been minimized.

Show comment
Hide comment
@sensestage

sensestage Dec 10, 2012

Contributor

Hiho,

would there be an alternative on OpenBSD to access HID devices?

I'll be rewriting the HID support in January, so it would be good to know what
to keep in mind for OpenBSD.

sincerely,
Marije

On Monday 10 December 2012 01:38:23 Abel Abraham Camarillo Ojeda wrote:

I'm working on porting supercollider to OpenBSD, and this helps that work.

You can merge this Pull Request by running:

git pull https://github.com/acamari/supercollider master

Or you can view, comment on it, or merge it online at:

#683

-- Commit Summary --

  • adds SC_LID option (on by default) to enable/disable Linux Input Device

-- File Changes --

M CMakeLists.txt (5)
M lang/CMakeLists.txt (6)

-- Patch Links --

https://github.com/supercollider/supercollider/pull/683.patch
https://github.com/supercollider/supercollider/pull/683.diff


Reply to this email directly or view it on GitHub:
#683

Contributor

sensestage commented Dec 10, 2012

Hiho,

would there be an alternative on OpenBSD to access HID devices?

I'll be rewriting the HID support in January, so it would be good to know what
to keep in mind for OpenBSD.

sincerely,
Marije

On Monday 10 December 2012 01:38:23 Abel Abraham Camarillo Ojeda wrote:

I'm working on porting supercollider to OpenBSD, and this helps that work.

You can merge this Pull Request by running:

git pull https://github.com/acamari/supercollider master

Or you can view, comment on it, or merge it online at:

#683

-- Commit Summary --

  • adds SC_LID option (on by default) to enable/disable Linux Input Device

-- File Changes --

M CMakeLists.txt (5)
M lang/CMakeLists.txt (6)

-- Patch Links --

https://github.com/supercollider/supercollider/pull/683.patch
https://github.com/supercollider/supercollider/pull/683.diff


Reply to this email directly or view it on GitHub:
#683

@acamari

This comment has been minimized.

Show comment
Hide comment
@acamari

acamari Dec 10, 2012

Let me investigate, I don't even know what LID is suppossed to do...

do you know a good (and current) reference material?, a quick glance
using google returned rare results...

Thanks.

On Mon, Dec 10, 2012 at 12:57 AM, sensestage notifications@github.comwrote:

Hiho,

would there be an alternative on OpenBSD to access HID devices?

I'll be rewriting the HID support in January, so it would be good to know
what
to keep in mind for OpenBSD.

sincerely,
Marije

On Monday 10 December 2012 01:38:23 Abel Abraham Camarillo Ojeda wrote:

I'm working on porting supercollider to OpenBSD, and this helps that
work.

You can merge this Pull Request by running:

git pull https://github.com/acamari/supercollider master

Or you can view, comment on it, or merge it online at:

#683

-- Commit Summary --

  • adds SC_LID option (on by default) to enable/disable Linux Input Device

-- File Changes --

M CMakeLists.txt (5)
M lang/CMakeLists.txt (6)

-- Patch Links --

https://github.com/supercollider/supercollider/pull/683.patch
https://github.com/supercollider/supercollider/pull/683.diff


Reply to this email directly or view it on GitHub:
#683


Reply to this email directly or view it on GitHubhttps://github.com/supercollider/supercollider/pull/683#issuecomment-11183548.

acamari commented Dec 10, 2012

Let me investigate, I don't even know what LID is suppossed to do...

do you know a good (and current) reference material?, a quick glance
using google returned rare results...

Thanks.

On Mon, Dec 10, 2012 at 12:57 AM, sensestage notifications@github.comwrote:

Hiho,

would there be an alternative on OpenBSD to access HID devices?

I'll be rewriting the HID support in January, so it would be good to know
what
to keep in mind for OpenBSD.

sincerely,
Marije

On Monday 10 December 2012 01:38:23 Abel Abraham Camarillo Ojeda wrote:

I'm working on porting supercollider to OpenBSD, and this helps that
work.

You can merge this Pull Request by running:

git pull https://github.com/acamari/supercollider master

Or you can view, comment on it, or merge it online at:

#683

-- Commit Summary --

  • adds SC_LID option (on by default) to enable/disable Linux Input Device

-- File Changes --

M CMakeLists.txt (5)
M lang/CMakeLists.txt (6)

-- Patch Links --

https://github.com/supercollider/supercollider/pull/683.patch
https://github.com/supercollider/supercollider/pull/683.diff


Reply to this email directly or view it on GitHub:
#683


Reply to this email directly or view it on GitHubhttps://github.com/supercollider/supercollider/pull/683#issuecomment-11183548.

@timblechmann

This comment has been minimized.

Show comment
Hide comment
@timblechmann

timblechmann Dec 10, 2012

Contributor

hi acamari,

would it be possible that you address the last comment (regarding cmake integration) and update the pull request?
then i'd be fine with merging it

thanks, tim

Contributor

timblechmann commented Dec 10, 2012

hi acamari,

would it be possible that you address the last comment (regarding cmake integration) and update the pull request?
then i'd be fine with merging it

thanks, tim

@acamari

This comment has been minimized.

Show comment
Hide comment
@acamari

acamari Dec 10, 2012

I updated the patch (disabled SC_LID option), and tested it, it builds.

I'm unsure if the reverting was necessary/desirable...

Thanks.

acamari commented Dec 10, 2012

I updated the patch (disabled SC_LID option), and tested it, it builds.

I'm unsure if the reverting was necessary/desirable...

Thanks.

@timblechmann

This comment has been minimized.

Show comment
Hide comment
@timblechmann

timblechmann Dec 10, 2012

Contributor

you can just rebase interactively and remove the SC_LID related changes ... that results in a cleaner git history and makes it easier to read ...

thanks a lot!

Contributor

timblechmann commented Dec 10, 2012

you can just rebase interactively and remove the SC_LID related changes ... that results in a cleaner git history and makes it easier to read ...

thanks a lot!

Abel Abraham Camarillo Ojeda added some commits Dec 10, 2012

Abel Abraham Camarillo Ojeda
make supercollider build on OpenBSD
change FreeBSD-only define preprocessor directives to include OpenBSD.
@acamari

This comment has been minimized.

Show comment
Hide comment
@acamari

acamari Dec 10, 2012

Ok, now rebased interactively, and just uses two commits.

I'll comment tomorrow about run-time errors (which to me seem very deep...)

thanks!

acamari commented Dec 10, 2012

Ok, now rebased interactively, and just uses two commits.

I'll comment tomorrow about run-time errors (which to me seem very deep...)

thanks!

timblechmann added a commit that referenced this pull request Dec 10, 2012

Merge pull request #683 from acamari/master
port supercollider to OpenBSD

@timblechmann timblechmann merged commit 8211eba into supercollider:master Dec 10, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment