Add sites manager to nodeunit and nodegroup #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
attlee-wang
added
enhancement
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
Signed-off-by: attleewang <attleewang@tencent.com>
WaylandWong
reviewed
Feb 14, 2022
| @@ -80,9 +80,10 @@ const ( | |||
|
|
|||
| // label | |||
| const ( | |||
| EdgeNodeLabelKey = "superedge.io/edge-node" | |||
| EdgeNodeLabelKey = "superedge.io/node-edge" | |||
There was a problem hiding this comment.
I think this change should be applied in other places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
** enhancement **
What this PR does:
Add sites manager to nodeunit and nodegroup
SuperEdge puts forward the concept of ServiceGroup in the first version of open source in 2020, as shown below:
However, the NodeUnit and NodeGroup resources have not been instantiated, and they have been managed through labels. When the user wants to see what resources his NodeUnit and NodeGroup resources have, it is quite cumbersome and needs to filter by label. For this reason, users have put forward a strong demand to visualize NodeUnit and NodeGroup.
Talk about the benefits of visualization:
-You can digitize your physical sites everywhere, and directly use CR to perform digital management of sites in the K8s cluster;
-A single physical site can be divided into multiple logical sites, and multiple logical sites can form a NodeGroup; (a node can belong to multiple logical site NodeUnits at the same time)
-A NodeGroup can be bound to a set of applications in the cloud, using the capabilities of ServiceGroup in the cloud, once an application is submitted, and deployed to different logical sites at the same time;
-The usage is fully compatible with ServiceGroup. ServiceGroup is an abstraction of applications, and NodeGroup is an abstraction of resources. The two can be combined flexibly to run applications.