New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get profile posts use-case with Facebook map #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Great work here, just a few minor issues.
src/app.js
Outdated
}); | ||
}); | ||
|
||
app.post('/profile-posts', ensureAuthenticated, require('./profile-posts')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of displaying it under POST submission, I suggest adding it as a query parameter to GET /profile-posts, e.g. /profile-posts?provider=facebook&profileId=1234
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
return { | ||
type = attachment.type | ||
url = attachment.url | ||
altText = attachment.title |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently it's not possible to get an alt text from FB API (or it's undocumented). Personally I'd rather extend the profile to include title
and description
(probably as text
) from the attachment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added title
and description
as you suggested.
Co-authored-by: Jan Vlnas <616767+jnv@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.