Reset statements on error to avoid parameter misuse error
#3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somtochiama
force-pushed
the
fix-parameter-misuse
branch
from
075bc10 to
a44f899
Compare
somtochiama
force-pushed
the
fix-parameter-misuse
branch
from
70cf5e9 to
27d88cf
Compare
somtochiama
force-pushed
the
fix-parameter-misuse
branch
from
27d88cf to
23e0001
Compare
jeromegn
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request ensures sqlite statement are always reset after use, avoiding
Bad parameter or api misuseerrors that occur when binding to a statement that was not reset properly.Also fixes the
merge_same_w_tie_breakertest to ensure each databases has received changes from other databases and updates the code so we are actually checking the rows returned from sqlite and not empty arrays