Apps V2 - fly releases inaccurate for a V2 app

[catflydotio]

A V2 app with a single process and a passing tcp service check, just after a successful deployment:

$ fly releases
VERSION STABLE  TYPE    STATUS  DESCRIPTION    
v2      false           pending Release     
v1      false           pending Release     

[tvdfly]

We can probably remove the stable and status columns for apps v2. I'm not sure they are relevant anymore.

[kzys]

It looks better, but I still not so sure about pending.

% fly releases
VERSION STATUS          DESCRIPTION     USER            DATE                 
v55     complete        Release         kaz@fly.io      2023-05-02T17:52:31Z
v54     failed          Release         kaz@fly.io      2023-05-02T17:37:07Z
v53     complete        Release         kaz@fly.io      2023-04-28T20:31:22Z
v52     failed          Release         kaz@fly.io      2023-04-28T20:28:24Z
v51     complete        Release         kaz@fly.io      2023-04-27T22:20:24Z
v50     complete        Release         kaz@fly.io      2023-04-25T21:54:05Z
v49     complete        Release         kaz@fly.io      2023-04-25T21:52:14Z
v48     complete        Release         kaz@fly.io      2023-04-25T18:23:34Z
v47     failed          Release         kaz@fly.io      2023-04-25T18:20:48Z
v46     failed          Release         kaz@fly.io      2023-04-25T18:15:39Z
v45     complete        Release         kaz@fly.io      2023-04-25T18:06:39Z
v44     complete        Release         kaz@fly.io      2023-04-25T18:05:04Z
v43     complete        Release         kaz@fly.io      2023-04-25T18:03:42Z
v42     complete        Release         kaz@fly.io      2023-04-25T18:03:14Z
v41     complete        Release         kaz@fly.io      2023-04-25T18:00:03Z
v40     complete        Release         kaz@fly.io      2023-04-25T17:58:07Z
v39     complete        Release         kaz@fly.io      2023-04-14T18:30:46Z
v38     complete        Release         kaz@fly.io      2023-04-14T18:29:26Z
v37     complete        Release         kaz@fly.io      2023-04-14T18:16:32Z
v36     complete        Release         kaz@fly.io      2023-04-14T18:10:17Z
v35     pending         Release         kaz@fly.io      2023-04-14T00:59:41Z
v34     pending         Release         kaz@fly.io      2023-04-14T00:56:43Z
v33     pending         Release         kaz@fly.io      2023-04-14T00:47:46Z
v32     pending         Release         kaz@fly.io      2023-04-14T00:46:26Z
v31     pending         Release         kaz@fly.io      2023-04-13T20:51:30Z

[matttpt]

@kzys for Nomad apps the "status" field got updated from the corresponding Nomad job, but for Apps v2 it's just a database column. Currently flyctl updates it through the course of the deployment process with the relatively new updateRelease GraphQL mutation, but earlier flyctl versions did not. So barring any manual updates, old releases will be pending forever, unfortunately. (The changes for this got merged in mid-April, which is why the pending releases end then.)

One other thing I was considering was to let flyctl provide a more informative description than Release. I haven't gotten around to that though.

[rugwirobaker]

@matttpt what did you have in mind?

I was considering was to let flyctl provide a more informative description than Release

[matttpt]

For Nomad apps, the description came from the Nomad job associated with the release. It would be things like Deploy image, Scale VM count: ["app, 0"], Secrets updated, and Reverting to version N. My thought at the time was to do something similar for Apps v2. Some of those release types are no longer relevant, but “regular” deployments and deployments to roll out secrets would still make sense to differentiate. I do think that this would require a new column in the releases table.