Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent ssh console lockup from dead VMs #636

Closed
tqbf opened this issue Dec 6, 2021 · 3 comments
Closed

Prevent ssh console lockup from dead VMs #636

tqbf opened this issue Dec 6, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@tqbf
Copy link
Contributor

tqbf commented Dec 6, 2021

Describe the bug
Log into an instance with flyctl ssh console.

Kill the instance (kill -9 <master-process>, whatever).

Now try to get out of flyctl ssh console.
@tqbf tqbf added the bug Something isn't working label Dec 6, 2021
@michaeldwan michaeldwan mentioned this issue Jan 28, 2022
Open
@azazeal azazeal self-assigned this Feb 2, 2022
@jsierles jsierles changed the title Handle dead instances Prevent ssh console lockup from dead VMs Feb 8, 2022
@jsierles jsierles mentioned this issue Feb 8, 2022
Closed
@jsierles jsierles mentioned this issue Jul 6, 2022
Closed
@kzys
Copy link
Member

kzys commented Jul 5, 2023

What is the master process here? Both kill -9 $(pidof hallpass) and fly machine stop [machine ID] (from #455) correctly closed the terminals for me now. We may be fixed the issue already.

@pborzenkov
Copy link
Contributor

Yeah, this has been fixed in init by SIGTERMing hallpass before machine's reboot, so guest kernel has a chance to tear-down TCP connection properly.

@kzys
Copy link
Member

kzys commented Jul 6, 2023

https://github.com/superfly/init/pull/86

Awesome! Resolving.

@kzys kzys closed this as completed Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tqbf @kzys @azazeal @pborzenkov