Disable provisioning of new nomad apps #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangra
reviewed
May 16, 2023
kzys
reviewed
May 16, 2023
kzys
reviewed
May 16, 2023
alichay
force-pushed
the
feat/all-apps-are-v2
branch
from
9095d82
to
3b89cf7
Compare
|
should have addressed everything. squashed the commits though because it was getting a bit unruly for such a small change haha |
turboku is untested
alichay
force-pushed
the
feat/all-apps-are-v2
branch
from
3b89cf7
to
ed6a573
Compare
dangra
approved these changes
May 16, 2023
kzys
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: turboku is untested. it used to force nomad, and now it doesn't.
--machinesflag onfly apps create, hides the--nomadflag forapps create(and if it's specified, throws an error).--force-nomadand--force-machinesflags for deploy/launch. they are now unused, but I didn't want to potentially break pipelines that use these flags. (and --force-nomad being specified can throw more helpful errors than just unknown flag)machinesand throws an error if--force-nomadis specified.