Handle SIGUSR2 and dump goroutines on the signal #2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When flyctl hangs, dumping all goroutines may be helpful to understand its internal state. Docker uses SIGUSR1 for that, but it is already taken by wg/signals_unix.go. https://community.fly.io/t/flyctl-v0-1-47-cannot-deploy-clone-and-list-machines/13940 https://github.com/moby/moby/blob/v24.0.2/daemon/debugtrap_unix.go#L17
|
There is a nice package called |
|
Having gops on our own hosts (e.g. backend servers) may be nice. For customer hosts (e.g. their laptops), I don't want to take a TCP port. https://github.com/google/gops/blob/v0.3.27/agent/agent.go#L74 |
dangra
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When flyctl hangs, dumping all goroutines may be helpful to understand its internal state.
Docker uses SIGUSR1 for that, but it is already taken by wg/signals_unix.go.
https://community.fly.io/t/flyctl-v0-1-47-cannot-deploy-clone-and-list-machines/13940 https://github.com/moby/moby/blob/v24.0.2/daemon/debugtrap_unix.go#L17
Change Summary
What and Why:
flyctl v0.1.47 was hanging occasionally and we had no clues. This change may help us understand what's going on.
How:
Handling SIGUSR2 and dumping all goroutines' stacktraces.
Related to:
https://community.fly.io/t/flyctl-v0-1-47-cannot-deploy-clone-and-list-machines/13940
Documentation