Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discrepancy between DiscImageCreator and redumper in TOC/Cue with DCP #121

Closed
maxz opened this issue Feb 26, 2024 · 4 comments
Closed

Discrepancy between DiscImageCreator and redumper in TOC/Cue with DCP #121

maxz opened this issue Feb 26, 2024 · 4 comments

Comments

@maxz
Copy link

maxz commented Feb 26, 2024

On this coverdisc there is a discrepancy between the cue generated by DiscImageCreator and the cue generated by redumper. DIC sets the DCP flag on the audio tracks, Redumper does not. All other relevant information matches.
Redumper should probably use the QTOC instead of the TOC to generate the cue file.
Or maybe you can provide an explanation why it would be more desirable to use the TOC and break the DIC compatibility.

Redumper logs: https://archive.org/download/redump.org-logs/TOMBRAIDER2 (Redumper).zip
DiscImageCreator logs: https://archive.org/download/redump.org-logs/TOMBRAIDER2 (DiscImageCreator).zip

DiscImageCreator's TOMBRAIDER2.cue:

FILE "TOMBRAIDER2 (Track 01).bin" BINARY
  TRACK 01 MODE1/2352
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 02).bin" BINARY
  TRACK 02 AUDIO
    FLAGS DCP
    INDEX 00 00:00:00
    INDEX 01 00:02:00
FILE "TOMBRAIDER2 (Track 03).bin" BINARY
  TRACK 03 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 04).bin" BINARY
  TRACK 04 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 05).bin" BINARY
  TRACK 05 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 06).bin" BINARY
  TRACK 06 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 07).bin" BINARY
  TRACK 07 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 08).bin" BINARY
  TRACK 08 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 09).bin" BINARY
  TRACK 09 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 10).bin" BINARY
  TRACK 10 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 11).bin" BINARY
  TRACK 11 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 12).bin" BINARY
  TRACK 12 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 13).bin" BINARY
  TRACK 13 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 14).bin" BINARY
  TRACK 14 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 15).bin" BINARY
  TRACK 15 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 16).bin" BINARY
  TRACK 16 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 17).bin" BINARY
  TRACK 17 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 18).bin" BINARY
  TRACK 18 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 19).bin" BINARY
  TRACK 19 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 20).bin" BINARY
  TRACK 20 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 21).bin" BINARY
  TRACK 21 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 22).bin" BINARY
  TRACK 22 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 23).bin" BINARY
  TRACK 23 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 24).bin" BINARY
  TRACK 24 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 25).bin" BINARY
  TRACK 25 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 26).bin" BINARY
  TRACK 26 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 27).bin" BINARY
  TRACK 27 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 28).bin" BINARY
  TRACK 28 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 29).bin" BINARY
  TRACK 29 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 30).bin" BINARY
  TRACK 30 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 31).bin" BINARY
  TRACK 31 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 32).bin" BINARY
  TRACK 32 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 33).bin" BINARY
  TRACK 33 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 34).bin" BINARY
  TRACK 34 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 35).bin" BINARY
  TRACK 35 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 36).bin" BINARY
  TRACK 36 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 37).bin" BINARY
  TRACK 37 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 38).bin" BINARY
  TRACK 38 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 39).bin" BINARY
  TRACK 39 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 40).bin" BINARY
  TRACK 40 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 41).bin" BINARY
  TRACK 41 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 42).bin" BINARY
  TRACK 42 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 43).bin" BINARY
  TRACK 43 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 44).bin" BINARY
  TRACK 44 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 45).bin" BINARY
  TRACK 45 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 46).bin" BINARY
  TRACK 46 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 47).bin" BINARY
  TRACK 47 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 48).bin" BINARY
  TRACK 48 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 49).bin" BINARY
  TRACK 49 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 50).bin" BINARY
  TRACK 50 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 51).bin" BINARY
  TRACK 51 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 52).bin" BINARY
  TRACK 52 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 53).bin" BINARY
  TRACK 53 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 54).bin" BINARY
  TRACK 54 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 55).bin" BINARY
  TRACK 55 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 56).bin" BINARY
  TRACK 56 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 57).bin" BINARY
  TRACK 57 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 58).bin" BINARY
  TRACK 58 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 59).bin" BINARY
  TRACK 59 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 60).bin" BINARY
  TRACK 60 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 61).bin" BINARY
  TRACK 61 AUDIO
    FLAGS DCP
    INDEX 01 00:00:00

Redumper's TOMBRAIDER2.cue:

FILE "TOMBRAIDER2 (Track 01).bin" BINARY
  TRACK 01 MODE1/2352
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 02).bin" BINARY
  TRACK 02 AUDIO
    INDEX 00 00:00:00
    INDEX 01 00:02:00
FILE "TOMBRAIDER2 (Track 03).bin" BINARY
  TRACK 03 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 04).bin" BINARY
  TRACK 04 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 05).bin" BINARY
  TRACK 05 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 06).bin" BINARY
  TRACK 06 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 07).bin" BINARY
  TRACK 07 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 08).bin" BINARY
  TRACK 08 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 09).bin" BINARY
  TRACK 09 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 10).bin" BINARY
  TRACK 10 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 11).bin" BINARY
  TRACK 11 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 12).bin" BINARY
  TRACK 12 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 13).bin" BINARY
  TRACK 13 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 14).bin" BINARY
  TRACK 14 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 15).bin" BINARY
  TRACK 15 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 16).bin" BINARY
  TRACK 16 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 17).bin" BINARY
  TRACK 17 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 18).bin" BINARY
  TRACK 18 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 19).bin" BINARY
  TRACK 19 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 20).bin" BINARY
  TRACK 20 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 21).bin" BINARY
  TRACK 21 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 22).bin" BINARY
  TRACK 22 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 23).bin" BINARY
  TRACK 23 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 24).bin" BINARY
  TRACK 24 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 25).bin" BINARY
  TRACK 25 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 26).bin" BINARY
  TRACK 26 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 27).bin" BINARY
  TRACK 27 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 28).bin" BINARY
  TRACK 28 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 29).bin" BINARY
  TRACK 29 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 30).bin" BINARY
  TRACK 30 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 31).bin" BINARY
  TRACK 31 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 32).bin" BINARY
  TRACK 32 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 33).bin" BINARY
  TRACK 33 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 34).bin" BINARY
  TRACK 34 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 35).bin" BINARY
  TRACK 35 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 36).bin" BINARY
  TRACK 36 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 37).bin" BINARY
  TRACK 37 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 38).bin" BINARY
  TRACK 38 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 39).bin" BINARY
  TRACK 39 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 40).bin" BINARY
  TRACK 40 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 41).bin" BINARY
  TRACK 41 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 42).bin" BINARY
  TRACK 42 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 43).bin" BINARY
  TRACK 43 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 44).bin" BINARY
  TRACK 44 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 45).bin" BINARY
  TRACK 45 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 46).bin" BINARY
  TRACK 46 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 47).bin" BINARY
  TRACK 47 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 48).bin" BINARY
  TRACK 48 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 49).bin" BINARY
  TRACK 49 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 50).bin" BINARY
  TRACK 50 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 51).bin" BINARY
  TRACK 51 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 52).bin" BINARY
  TRACK 52 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 53).bin" BINARY
  TRACK 53 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 54).bin" BINARY
  TRACK 54 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 55).bin" BINARY
  TRACK 55 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 56).bin" BINARY
  TRACK 56 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 57).bin" BINARY
  TRACK 57 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 58).bin" BINARY
  TRACK 58 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 59).bin" BINARY
  TRACK 59 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 60).bin" BINARY
  TRACK 60 AUDIO
    INDEX 01 00:00:00
FILE "TOMBRAIDER2 (Track 61).bin" BINARY
  TRACK 61 AUDIO
    INDEX 01 00:00:00
@superg
Copy link
Owner

superg commented Feb 27, 2024

So here track flags are different in TOC and in subchannel. As we favor TOC by default, all flags should come from TOC too.
We cannot seldom merge/interchange things between TOC and subchannel as it becomes complicated.
If you need flags from subchannel, you should resplit with redumper split --force-qtoc, that will make subchannel data as priority (for everything, flags, track splits etc). redump.org will favor TOC flags.

@maxz
Copy link
Author

maxz commented Feb 27, 2024

Ok, so what you are essentially saying is unless I need the flags for some reason, I should rather submit the Redumper version of the cue file which is based on the media TOC.
I don't really have specific needs for my flags to be from any particular source. I just want to preserve my media.

Is that an official redump.org stance that the TOC is preferred? I just want to submit the entry which is the most compliant and future-proof. Would it make sense from your point of view, to then file an issue on the DiscImageCreator repository to have it changed there?

@tjanas
Copy link
Contributor

tjanas commented Feb 27, 2024

http://wiki.redump.org/index.php?title=Redumper
"redump.org favors TOC based split but the decision has to be made which variant is preferable for a given disc"

@maxz maxz mentioned this issue Feb 27, 2024
Closed
@maxz
Copy link
Author

maxz commented Feb 28, 2024

@saramibreak said that he would adjust the behaviour of DiscImageCreator in the next release, so that it will also use the information from the TOC.

It seems like the behaviour of the tools converges on using the TOC then, which works for me.

@maxz maxz closed this as completed Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@superg @maxz @tjanas