Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit League endpoints #11

Merged
merged 2 commits into from Jun 13, 2019

Conversation

Projects
None yet
1 participant
@supergrecko
Copy link
Owner

commented Jun 13, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:
    Added the new endpoint which replaces /positions-by-summoner

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:
Expect an instance of RiotQuest\Components\Framework\Collections\LeagueEntryList instead of LeaguePositionList.

The PR fulfills these requirements:

  • It's submitted to the development branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All PHPUnit tests are passing
  • New/updated tests are included (if applicable)

Other information:

@supergrecko supergrecko merged commit 71fa913 into master Jun 13, 2019

@supergrecko supergrecko deleted the add-new-leagues branch Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.