Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ellie Link Generator - v1 (Stateless & Messageless Files Only) #64

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Ellie Link Generator - v1 (Stateless & Messageless Files Only) #64

wants to merge 24 commits into from

Commits on Oct 22, 2020

  1. URL Generator Works, can fetch version in JS 

    - ASSUMES version (tag_name) doesn't have a 'v' in it
- I will have to make some changes for the Router subscriptions to work
Is fetching it in JS worth it? I will have to make changes for Router to support subscriptions
I will also make another version next commit with Router doing the HTTP request
    @joshuanianji
    joshuanianji committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    fef7534 View commit details
    Browse the repository at this point in the history

  2. Elm version of HTTP Request 

    I prefer this way unless supermacro prefers the JS version.
I also have to start thinking of how to send the version to the Component
    @joshuanianji
    joshuanianji committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    4699294 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2020

  1. Sent hardcoded version as flag. Removed HTTP 

    File server not working though, maybe I need to fetch upstream
    @joshuanianji
    joshuanianji committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    58d3ba1 View commit details
    Browse the repository at this point in the history

  2. Merge with upstream

    @joshuanianji
    joshuanianji committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    b8a992d View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2020

  1. use parsing to make the URL generator better 

    - can now completely do "Stateless and Message-less" files
    @joshuanianji
    joshuanianji committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    464f072 View commit details
    Browse the repository at this point in the history

  2. Merge with upstream

    @joshuanianji
    joshuanianji committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    c09ff39 View commit details
    Browse the repository at this point in the history

  3. Forgot to commit config.yml when merging with upstream

    @joshuanianji
    joshuanianji committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    83be31b View commit details
    Browse the repository at this point in the history

  4. Removed unnecessary DemoBoxMetaInfo code

    @joshuanianji
    joshuanianji committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    a824446 View commit details
    Browse the repository at this point in the history

  5. 🎨 Format

    @joshuanianji
    joshuanianji committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    a34ebd1 View commit details
    Browse the repository at this point in the history

  6. Fixed bug where parsing fails on let statements 

    - Just needed to add more newline characters lol
    @joshuanianji
    joshuanianji committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    2ab8f79 View commit details
    Browse the repository at this point in the history

  7. Undo changes to config.yml

    @joshuanianji
    joshuanianji committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    4831083 View commit details
    Browse the repository at this point in the history

  8. rename "version" to "elmAntdVersion"

    @joshuanianji
    joshuanianji committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    2f3043d View commit details
    Browse the repository at this point in the history

  9. update elm version in UrlGenerator

    @joshuanianji
    joshuanianji committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    bf981f3 View commit details
    Browse the repository at this point in the history

  10. Changed 'elmAntdVersion' to Maybe String

    @joshuanianji
    joshuanianji committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    af00301 View commit details
    Browse the repository at this point in the history

  11. Small changes to Url Generator before splitting it up 

    - encodeUrl -> encodeUrlComponent
- `htmlCode` moved to bottom
- `elliefyExports` is cleaner
    @joshuanianji
    joshuanianji committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    67b5a1a View commit details
    Browse the repository at this point in the history

  12. Use Url.Builder for Url Encoding

    @joshuanianji
    joshuanianji committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    40a6227 View commit details
    Browse the repository at this point in the history

  13. Split UrlGenerator into two files

    @joshuanianji
    joshuanianji committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    06bb9d4 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'master' into ellie-links

    @joshuanianji
    joshuanianji committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    db7c2a3 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2020

  1. Merged with upstream

    Joshua Ji authored and Joshua Ji committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    6f01768 View commit details
    Browse the repository at this point in the history

  2. Use extensible records to enforce versioning

    Joshua Ji authored and Joshua Ji committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    c17bded View commit details
    Browse the repository at this point in the history

  3. flags.version -> flags.elmAntdVersion

    @joshuanianji
    joshuanianji committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    423d65c View commit details
    Browse the repository at this point in the history

  4. Improved fromSourceCode function signature

    @joshuanianji
    joshuanianji committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    2170628 View commit details
    Browse the repository at this point in the history

  5. elliefy now returns a Result 

    Still work to do for error handling to be better
But now the type signature makes more sense
    @joshuanianji
    joshuanianji committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    573ec47 View commit details
    Browse the repository at this point in the history

  6. EllieLinks.fromSourceCode also returns a Result 

    Container.setSourceCode fixed to accomodate this change
    @joshuanianji
    joshuanianji committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    0bb2d24 View commit details
    Browse the repository at this point in the history