New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for NSArray & removed some redundant code #20

Merged
merged 1 commit into from May 16, 2013

Conversation

Projects
None yet
2 participants
@orta
Contributor

orta commented May 16, 2013

Docs in the header file

I've switched the properties first & last to be methods, as there is no difference in your implementation as LLVM allows dot syntax on methods.

I removed the NSMutableArray check, as isKindOfClass checks for subclasses too so it would never be ran as the NSArray check would pass.

snake_notation to camelCase in variable names.

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta May 16, 2013

Contributor

I'll slowly work my way through this, your call if you'd prefer it incrementally or in one big PR.

Contributor

orta commented May 16, 2013

I'll slowly work my way through this, your call if you'd prefer it incrementally or in one big PR.

@supermarin

This comment has been minimized.

Show comment
Hide comment
@supermarin

supermarin May 16, 2013

Owner

Whatever works for you the best :) what do you think?

Owner

supermarin commented May 16, 2013

Whatever works for you the best :) what do you think?

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta May 16, 2013

Contributor

incrementally, I'll just go through when I feel like I need a break for the obviously super hardcore awesome artsy stuff.

Contributor

orta commented May 16, 2013

incrementally, I'll just go through when I feel like I need a break for the obviously super hardcore awesome artsy stuff.

@supermarin

This comment has been minimized.

Show comment
Hide comment
@supermarin

supermarin May 16, 2013

Owner

sounds good

Owner

supermarin commented May 16, 2013

sounds good

supermarin pushed a commit that referenced this pull request May 16, 2013

Marin Usalj
Merge pull request #20 from orta/master
Added documentation for NSArray & removed some redundant code

@supermarin supermarin merged commit 4520961 into supermarin:master May 16, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment