This repository has been archived by the owner on Mar 5, 2021. It is now read-only.
Replace >= and <= with > and < in ArcadePhysics2D.intersects() #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If collides() is called, then the pair of bodies it was called with are no longer considered intersecting, even though one would probably expect a thing that is on top (e.g.) of another to qualify as 'colliding'. This fixes that counterintuitive behavior.
|
Yeah I agree that makes sense. I test a bunch of games we have that uses ArcadePhysics2D and everything seems to be fine. Also your PR is very good. Code diff is clean and you explained clearly what you wanted to fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If collides() is called, then the pair of bodies it was called with are
no longer considered intersecting, even though one would probably expect
a thing that is on top (e.g.) of another to qualify as 'colliding'. This
fixes that counterintuitive behavior.
First PR, please be gentle. In particular, apologies if I'm supposed to open an issue for tracking things like this. I'm really not sure.