Skip to content

Conversation

@alon-david
Copy link
Contributor

No description provided.

@siwikm
Copy link
Contributor

siwikm commented Feb 14, 2023

@alon-david Maybe change config for black to 127?
127 which allows reading code on GitHub's file viewer without requiring left/right scrolling.

    hooks:
    -   id: black
        args: # arguments to configure black
        - --line-length=127
        - --include='\.pyi?$'

        # these folders wont be formatted by black
        - --exclude="""\.git |
          \.__pycache__|
          \.hg|
          \.mypy_cache|
          \.tox|
          \.venv|
          _build|
          buck-out|
          build|
          dist"""

Also, after adding black to flow, we could use github action to make formatting commits to pull request.

idanasulin2706
idanasulin2706 previously approved these changes Feb 15, 2023
Copy link
Contributor

@idanasulin2706 idanasulin2706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alon-david this is awesome, thank you very much, before merging just please resolve conflicts

Copy link
Contributor

@idanasulin2706 idanasulin2706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alon-david, approved and merged

@idanasulin2706 idanasulin2706 merged commit 707db57 into superstreamlabs:master Feb 16, 2023
@alon-david alon-david deleted the feature/formatting branch February 17, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants