Skip to content

change the publish to request in destroy methods #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2022
Merged

change the publish to request in destroy methods #47

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c790ff
change the publish to request in destroy methods
shohamroditimemphis Aug 27, 2022
7f67e0b
changed destroy exception
Aug 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 21 additions & 12 deletions memphis/memphis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
from threading import Timer
import asyncio

import retention_types
import storage_types
import memphis.retention_types as retention_types
import memphis.storage_types as storage_types


class set_interval():
Expand Down Expand Up @@ -264,8 +264,10 @@ async def destroy(self):
"factory_name":self.name
}
factory_name = json.dumps(nameReq, indent=2).encode('utf-8')
await self.connection.broker_connection.publish('$memphis_factory_destructions', factory_name)

res = await self.connection.broker_manager.request('$memphis_factory_destructions', factory_name)
error = res.data.decode('utf-8')
if error != "" and not "not exist" in error:
raise Exception(error)
except Exception as e:
raise Exception(e)

Expand All @@ -284,8 +286,10 @@ async def destroy(self):
"station_name":self.name
}
station_name = json.dumps(nameReq, indent=2).encode('utf-8')
await self.connection.broker_connection.publish('$memphis_station_destructions', station_name)

res = await self.connection.broker_manager.request('$memphis_station_destructions', station_name)
error = res.data.decode('utf-8')
if error != "" and not "not exist" in error:
raise Exception(error)
except Exception as e:
raise Exception(e)

Expand Down Expand Up @@ -321,11 +325,14 @@ async def destroy(self):
try:
destroyProducerReq = {
"name": self.producer_name,
"station_name":self.station_name
"station_name": self.station_name
}
producer_name = json.dumps(destroyProducerReq, indent=2).encode('utf-8')
await self.connection.broker_connection.publish('$memphis_producer_destructions', producer_name)


producer_name = json.dumps(destroyProducerReq).encode('utf-8')
res = await self.connection.broker_manager.request('$memphis_producer_destructions', producer_name)
error = res.data.decode('utf-8')
if error != "" and not "not exist" in error:
raise Exception(error)
except Exception as e:
raise Exception(e)

Expand Down Expand Up @@ -395,8 +402,10 @@ async def destroy(self):
"station_name":self.station_name
}
consumer_name = json.dumps(destroyConsumerReq, indent=2).encode('utf-8')
await self.connection.broker_connection.publish('$memphis_consumer_destructions', consumer_name)

res = await self.connection.broker_manager.request('$memphis_consumer_destructions', consumer_name)
error = res.data.decode('utf-8')
if error != "" and not "not exist" in error:
raise Exception(error)
except Exception as e:
raise Exception(e)

Expand Down