test: add missing skips for closing the browser (#804)

* test: update tests to fix CI * test: add more missing var declarations * test: fix missing skip condition * refactor: rework how we get session payload for newSessionCreated * test: add missing skips for closing the browser
supertokens · Mar 15, 2024 · bab5144 · bab5144
1 parent 528958f
commit bab5144
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/test/end-to-end/mfa.chooserscreen.test.js b/test/end-to-end/mfa.chooserscreen.test.js
@@ -87,7 +87,9 @@ describe("SuperTokens SignIn w/ MFA", function () {
     });
 
     after(async function () {
-        await browser.close();
+        if (!skipped) {
+            await browser.close();
+        }
 
         await fetch(`${TEST_SERVER_BASE_URL}/after`, {
             method: "POST",

diff --git a/test/end-to-end/mfa.factorscreen.totp.test.js b/test/end-to-end/mfa.factorscreen.totp.test.js
@@ -88,7 +88,9 @@ describe("SuperTokens SignIn w/ MFA", function () {
     });
 
     after(async function () {
-        await browser.close();
+        if (skipped) {
+            await browser.close();
+        }
 
         await fetch(`${TEST_SERVER_BASE_URL}/after`, {
             method: "POST",