feat: optional password validation in updateEmailOrPassword #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhpoddar
suggested changes
May 3, 2023
rishabhpoddar
suggested changes
May 4, 2023
| return Recipe{}, err | ||
| } | ||
| r.Config = verifiedConfig | ||
| var emailPasswordRecipe emailpassword.Recipe |
There was a problem hiding this comment.
undo change for where this variable was
rishabhpoddar
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Added optional password validation in
updateEmailOrPasswordfunction.Related issues
updateEmailOrPasswordsupertokens-node#549 (same implemented for golang)Test Plan
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)supertokens/constants.gofrontendDriverInterfaceSupported.jsonfile has been updated (if needed)supertokens/constants.go > version variablegit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.Remaining TODOs for this PR