fix: error handling in doFetch (#864)

supertokens · Jun 19, 2024 · 528ea98 · 528ea98
1 parent fb3ffa7
commit 528ea98
Show file tree

Hide file tree

Showing 8 changed files with 18 additions and 12 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [unreleased]
 
+## [18.0.1] - 2024-06-19
+
+### Fixes
+
+-   Fix a bug that was preventing errors from being caught in the fetch function, thus bypassing our error handling.
+
 ## [18.0.0] - 2024-05-23
 
 ### Breaking change

diff --git a/lib/build/utils.js b/lib/build/utils.js
diff --git a/lib/build/version.d.ts b/lib/build/version.d.ts
diff --git a/lib/build/version.js b/lib/build/version.js
diff --git a/lib/ts/utils.ts b/lib/ts/utils.ts
@@ -11,7 +11,7 @@ import { LoginMethod, User } from "./user";
 import { SessionContainer } from "./recipe/session";
 import { ProcessState, PROCESS_STATE } from "./processState";
 
-export const doFetch: typeof fetch = (input: RequestInfo | URL, init?: RequestInit | undefined) => {
+export const doFetch: typeof fetch = async (input: RequestInfo | URL, init?: RequestInit | undefined) => {
     // frameworks like nextJS cache fetch GET requests (https://nextjs.org/docs/app/building-your-application/caching#data-cache)
     // we don't want that because it may lead to weird behaviour when querying the core.
     if (init === undefined) {
@@ -27,7 +27,7 @@ export const doFetch: typeof fetch = (input: RequestInfo | URL, init?: RequestIn
     }
     const fetchFunction = typeof fetch !== "undefined" ? fetch : crossFetch;
     try {
-        return fetchFunction(input, init);
+        return await fetchFunction(input, init);
     } catch (e) {
         // Cloudflare Workers don't support the 'cache' field in RequestInit.
         // To work around this, we delete the 'cache' field and retry the fetch if the error is due to the missing 'cache' field.
@@ -43,7 +43,7 @@ export const doFetch: typeof fetch = (input: RequestInfo | URL, init?: RequestIn
         const newOpts = { ...init };
         delete newOpts.cache;
 
-        return fetchFunction(input, newOpts);
+        return await fetchFunction(input, newOpts);
     }
 };
 

diff --git a/lib/ts/version.ts b/lib/ts/version.ts
@@ -12,7 +12,7 @@
  * License for the specific language governing permissions and limitations
  * under the License.
  */
-export const version = "18.0.0";
+export const version = "18.0.1";
 
 export const cdiSupported = ["5.0"];
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "supertokens-node",
-    "version": "18.0.0",
+    "version": "18.0.1",
     "description": "NodeJS driver for SuperTokens core",
     "main": "index.js",
     "scripts": {