From b063493d75a0c546e25669dc330150cff596030b Mon Sep 17 00:00:00 2001 From: jscyo Date: Tue, 19 Apr 2022 18:03:44 +0530 Subject: [PATCH 1/4] fix: updates addRoleToUser and createNewRoleOrDoNothingIfExists_Transaction function signitures --- .../pluginInterface/userroles/UserRolesStorage.java | 4 ++-- .../userroles/sqlStorage/UserRolesSQLStorage.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/io/supertokens/pluginInterface/userroles/UserRolesStorage.java b/src/main/java/io/supertokens/pluginInterface/userroles/UserRolesStorage.java index 216b7a2a..b9148131 100644 --- a/src/main/java/io/supertokens/pluginInterface/userroles/UserRolesStorage.java +++ b/src/main/java/io/supertokens/pluginInterface/userroles/UserRolesStorage.java @@ -24,8 +24,8 @@ public interface UserRolesStorage extends Storage { - // associate a userId with a role that exists - void addRoleToUser(String userId, String role) + // associate a userId with a role that exists, returns the number of rows updated + int addRoleToUser(String userId, String role) throws StorageQueryException, UnknownRoleException, DuplicateUserRoleMappingException; // get all roles associated with the input userId diff --git a/src/main/java/io/supertokens/pluginInterface/userroles/sqlStorage/UserRolesSQLStorage.java b/src/main/java/io/supertokens/pluginInterface/userroles/sqlStorage/UserRolesSQLStorage.java index 91e38428..294364bc 100644 --- a/src/main/java/io/supertokens/pluginInterface/userroles/sqlStorage/UserRolesSQLStorage.java +++ b/src/main/java/io/supertokens/pluginInterface/userroles/sqlStorage/UserRolesSQLStorage.java @@ -28,8 +28,8 @@ public interface UserRolesSQLStorage extends UserRolesStorage, SQLStorage { boolean deleteRoleForUser_Transaction(TransactionConnection con, String userId, String role) throws StorageQueryException; - // create a new role - void createNewRoleOrDoNothingIfExists_Transaction(TransactionConnection con, String role) + // create a new role if it doesnt exist, returns the number of rows affected + int createNewRoleOrDoNothingIfExists_Transaction(TransactionConnection con, String role) throws StorageQueryException; // associate a permission with a role From 16d3b18cf3c140a1d0e8b2d7227e1d475aae3a19 Mon Sep 17 00:00:00 2001 From: jscyo Date: Tue, 19 Apr 2022 18:15:56 +0530 Subject: [PATCH 2/4] changes to boolean --- .../pluginInterface/userroles/UserRolesStorage.java | 4 ++-- .../userroles/sqlStorage/UserRolesSQLStorage.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/io/supertokens/pluginInterface/userroles/UserRolesStorage.java b/src/main/java/io/supertokens/pluginInterface/userroles/UserRolesStorage.java index b9148131..95fdeb09 100644 --- a/src/main/java/io/supertokens/pluginInterface/userroles/UserRolesStorage.java +++ b/src/main/java/io/supertokens/pluginInterface/userroles/UserRolesStorage.java @@ -24,8 +24,8 @@ public interface UserRolesStorage extends Storage { - // associate a userId with a role that exists, returns the number of rows updated - int addRoleToUser(String userId, String role) + // associate a userId with a role that exist + boolean addRoleToUser(String userId, String role) throws StorageQueryException, UnknownRoleException, DuplicateUserRoleMappingException; // get all roles associated with the input userId diff --git a/src/main/java/io/supertokens/pluginInterface/userroles/sqlStorage/UserRolesSQLStorage.java b/src/main/java/io/supertokens/pluginInterface/userroles/sqlStorage/UserRolesSQLStorage.java index 294364bc..0a51a071 100644 --- a/src/main/java/io/supertokens/pluginInterface/userroles/sqlStorage/UserRolesSQLStorage.java +++ b/src/main/java/io/supertokens/pluginInterface/userroles/sqlStorage/UserRolesSQLStorage.java @@ -28,8 +28,8 @@ public interface UserRolesSQLStorage extends UserRolesStorage, SQLStorage { boolean deleteRoleForUser_Transaction(TransactionConnection con, String userId, String role) throws StorageQueryException; - // create a new role if it doesnt exist, returns the number of rows affected - int createNewRoleOrDoNothingIfExists_Transaction(TransactionConnection con, String role) + // create a new role if it doesnt exist + boolean createNewRoleOrDoNothingIfExists_Transaction(TransactionConnection con, String role) throws StorageQueryException; // associate a permission with a role From dc3b312049f8fa7823318ec67463a6ede4845859 Mon Sep 17 00:00:00 2001 From: jscyo Date: Wed, 20 Apr 2022 12:18:01 +0530 Subject: [PATCH 3/4] undos change --- .../supertokens/pluginInterface/userroles/UserRolesStorage.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/io/supertokens/pluginInterface/userroles/UserRolesStorage.java b/src/main/java/io/supertokens/pluginInterface/userroles/UserRolesStorage.java index 95fdeb09..f315f724 100644 --- a/src/main/java/io/supertokens/pluginInterface/userroles/UserRolesStorage.java +++ b/src/main/java/io/supertokens/pluginInterface/userroles/UserRolesStorage.java @@ -25,7 +25,7 @@ public interface UserRolesStorage extends Storage { // associate a userId with a role that exist - boolean addRoleToUser(String userId, String role) + void addRoleToUser(String userId, String role) throws StorageQueryException, UnknownRoleException, DuplicateUserRoleMappingException; // get all roles associated with the input userId From 94698b5b19925358e80106cfe971735e8e5f6e4c Mon Sep 17 00:00:00 2001 From: jscyo Date: Wed, 20 Apr 2022 12:20:27 +0530 Subject: [PATCH 4/4] fixs typo --- .../supertokens/pluginInterface/userroles/UserRolesStorage.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/io/supertokens/pluginInterface/userroles/UserRolesStorage.java b/src/main/java/io/supertokens/pluginInterface/userroles/UserRolesStorage.java index f315f724..216b7a2a 100644 --- a/src/main/java/io/supertokens/pluginInterface/userroles/UserRolesStorage.java +++ b/src/main/java/io/supertokens/pluginInterface/userroles/UserRolesStorage.java @@ -24,7 +24,7 @@ public interface UserRolesStorage extends Storage { - // associate a userId with a role that exist + // associate a userId with a role that exists void addRoleToUser(String userId, String role) throws StorageQueryException, UnknownRoleException, DuplicateUserRoleMappingException;