Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not call recipe impl function inside another function that is unable to supply a user context to it #99

Closed
rishabhpoddar opened this issue Jan 24, 2022 · 0 comments

Comments

@rishabhpoddar
Copy link
Member

For example, getAccessTokenPayloadSecurely calls doesSessionExist internally. So if someone overrides doesSessionExist and in that calls getAccessTokenPayloadSecurely, it leads to an infinite loop. This can be solved by providing appropriate user context values and breaking the infinite recursion loop.

However, there is a case where refreshing a session calls recipeImpl.doesSessionExist which then if it calls getAccessTokenPayloadSecurely, which can also refresh the session. This causes an infinite recursive loop where the user context is no longer passed and cannot be used to break the loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant