pressing escape and back on friend's profile returns to own profile

[quizywiz]

for issue #1611

[quizywiz]

Hello,
The code works okay - it doesn't trigger the "your profile" scene when pressing back/escape on any other screen. That's because the condition "!visiting profile -> is current user" is true only when you're visiting someone else's profile.
I will fix the other two problems you've mentioned - coding style, and putting the code in the right place

[hiker]

Hi,

I checked, yes, technically you are right (I missed that you can't leave this screen with a different profile activated. But the state manager should now handle any screen specific settings - it is very hard to understand the code if you study (say) this screen, since it's not obvious that in a completely unrelated helper class the behaviour is modified.
Re your question: just above the code you modified in the state manager is the answer:

        if (getCurrentScreen() != NULL &&
            getCurrentScreen()->onEscapePressed()) popMenu();

The state manager calls onEscapePressed, and only if that returns true will it pop the menu. So you can easily handle that by adding the (virtual) function onEscapePressed.

Hope that helps, and thanks for your work!
Joerg

[quizywiz]

I've put it in the onEscapePressed function. I fixed a minor bug i found in another file too. :)

[hiker]

Thanks a lot - and good catch with the bug ;)