Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Allow to use system angelscript #2199

Merged
merged 2 commits into from May 22, 2015

Conversation

Projects
None yet
2 participants
Contributor

ignatenkobrain commented May 18, 2015

No description provided.

ignatenkobrain added some commits May 18, 2015

angelscript: don't use deprecated GetParamTypeId
Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
build: allow to use system angelscript
Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
Owner

auriamg commented May 19, 2015

Hi,
could you explain why you modified the array part?

EDIT: actually, the scripting branch, which is the most up to date, already has an updated array code, so that should be fine I guess. But you based your PR off the master branch, so merging your branch would cause a compilation error since master still uses an older angelscript

Contributor

ignatenkobrain commented May 20, 2015

@auriamg because GitParamTypeId is deprecated. I didn't know about scripting branch. Can you merge this to scripting branch?

Owner

auriamg commented May 21, 2015

Unfortunately the branch is not quite finished yet, but it should be mergeable soonish. Meanwhile I cannot merge your PR though since it would break trunk compilation

@auriamg auriamg merged commit 7005f3b into supertuxkart:master May 22, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Owner

auriamg commented May 22, 2015

The scripting branch and been merged, and your pull request too, thanks

@ignatenkobrain ignatenkobrain deleted the ignatenkobrain:ubundle_angelscript branch Jun 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment