Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vk_mvk_moltenvk.h on macOS 10.12 and earlier #4865

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

evanmiller
Copy link

IOSurfaceRef.h does not exist on macOS 10.12 and earlier. However the IOSurfaceRef type will be indirectly included by the Metal include, so we just need to ensure IOSurfaceRef is defined when __OBJC__ is not. This can be done with a typedef.

See: https://trac.macports.org/ticket/67263

Agreement

By creating a pull request in stk-code, you hereby agree to dual-license your contribution as
GNU General Public License version 3 or any later version and
Mozilla Public License version 2 or any later version.

This includes your previous contribution(s) under the same name of contributor.

Keep the above statement in the pull request comment for agreement.

IOSurfaceRef.h does not exist on macOS 10.12 and earlier.
However the IOSurfaceRef type will be indirectly included by
the Metal include, so we just need to ensure IOSurfaceRef is
defined when __OBJC__ is not. This can be done with a typedef.
@evanmiller
Copy link
Author

Actually, I'm told this patch doesn't work correctly on 10.9 so it may need some tweaking.

@Benau
Copy link
Member

Benau commented May 15, 2023

It should be done in https://github.com/KhronosGroup/MoltenVK anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants