Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add back chmodr #378

Merged
merged 3 commits into from
Apr 11, 2024
Merged

fix: add back chmodr #378

merged 3 commits into from
Apr 11, 2024

Conversation

HarryGogonis
Copy link
Contributor

@HarryGogonis HarryGogonis commented Apr 11, 2024 •
edited

fixes bug introduced in #373
resolves #377

@HarryGogonis HarryGogonis marked this pull request as ready for review April 11, 2024 14:31
@HarryGogonis HarryGogonis requested a review from a team as a code owner April 11, 2024 14:31
guitarislife87
guitarislife87 approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@guitarislife87 guitarislife87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:
Discussed test case changes and finding a file without executable permissions.

@HarryGogonis HarryGogonis merged commit 8e3f88b into main Apr 11, 2024
2 checks passed
@HarryGogonis HarryGogonis deleted the SRENEW-2087-chmod-fix branch April 11, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guitarislife87 guitarislife87 guitarislife87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v4 did not set binary correct permission
2 participants
@HarryGogonis @guitarislife87