New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: This patch includes the user's DSA key fingerprint in their QR code #14

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@pulser

pulser commented Jul 12, 2013

Request for comment:

The ability to add a user via QR code is already implemented, but misses out on a key benefit of the use of a QR code - currently the QR code contains the username, and Surespot does the rest. For future expansion, I have included the user's DSA (ie. signing) key fingerprint. (I believe this is the one which makes more sense to verify, I may be wrong here).

By allowing a user to invite another user via QR code, and including the fingerprint in the QR, it ensures that the user is getting the correct key returned from the server, making a physical meeting and exchanging Surespot IDs a guaranteed process, where even if the central server is not behaving, or compromised, the user will still have the correct key information available. I have not implemented this into any of the other invite/share methods, as they appear to rely on Internet connectivity, making them prone to a MITM attack. It could be easily added there too as a small extra level of security, as the email link AND surespot server fingerprints would need to match.

pulser
Include user's DSA key fingerprint in QR code
Request for comment: 

The ability to add a user via QR code is already implemented, but misses out on a key benefit of the use of a QR code - currently the QR code contains the username, and Surespot does the rest. For future expansion, I have included the user's DSA (ie. signing) key fingerprint. (I believe this is the one which makes more sense to verify, I may be wrong here).

By allowing a user to invite another user via QR code, and including the fingerprint in the QR, it ensures that the user is getting the correct key returned from the server, making a physical meeting and exchanging Surespot IDs a guaranteed process, where even if the central server is not behaving, or compromised, the user will still have the correct key information available. I have not implemented this into any of the other invite/share methods, as they appear to rely on Internet connectivity, making them prone to a MITM attack. It could be easily added there too as a small extra level of security, as the email link AND surespot server fingerprints would need to match.
@repat

This comment has been minimized.

Show comment
Hide comment
@repat

repat Feb 21, 2014

+1 for this. Threema has the same thing I believe.

As far as I understood, sceptical users could argue that they doesn't trust you to deliver the right key, be it out of pure evil ;) or because you've been compromised/hacked. This pretty much solves the problem. I didn't look at the code though.

repat commented Feb 21, 2014

+1 for this. Threema has the same thing I believe.

As far as I understood, sceptical users could argue that they doesn't trust you to deliver the right key, be it out of pure evil ;) or because you've been compromised/hacked. This pretty much solves the problem. I didn't look at the code though.

@repat repat referenced this pull request Feb 25, 2014

Open

Federation #5

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost commented Mar 2, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment