New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forget server-generated queue name on disconnect #4

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@cakirke
Contributor

cakirke commented Dec 13, 2015

server-generated queue names may not be accessible
after disconnect/reconnect due to server permissions.

https://rt.cpan.org/Ticket/Display.html?id=92939

cakirke added some commits Dec 13, 2015

forget server-generated queue name on disconnect
server-generated queue names may not be accessible
after disconnect/reconnect due to server permissions.

https://rt.cpan.org/Ticket/Display.html?id=92939
@abraxxa

This comment has been minimized.

Contributor

abraxxa commented Jan 1, 2016

I finally took the time to look into it, sorry for the delay!
Do you think the new attribute queue_forget is required and it can't be handled internally without expanding the api?
I'm thinking about a private attribute or method which returns true or false depending on the queue_name and some of the other attributes defined in ::Role::DeclaresQueue.
If that's not sufficient for some use case we can still expose the setting.

@cakirke

This comment has been minimized.

Contributor

cakirke commented Jan 1, 2016

my main concern was that this capability can result in lost (or at least unavailable to the client) messages. wanted the client to have to specifically enable the behavior, rather than it silently being enabled by default.

my $self = shift;
if ((!$self->_requested_queue_name) &&
($self->_has_queue_name && $self->queue_forget)) {
warn('FORGET ' . $self->queue_name);

This comment has been minimized.

@abraxxa

abraxxa Mar 29, 2016

Contributor

please remove this warning

If true, forget server-generated queue name on disconnect.
Has no effect if queue_name is explicitly set.

This comment has been minimized.

@abraxxa

abraxxa Mar 29, 2016

Contributor

please document the default value

@cakirke

This comment has been minimized.

Contributor

cakirke commented Mar 31, 2016

made requested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment