CHAT-183 #2

Merged
merged 5 commits into from Jul 13, 2012

Projects

None yet

2 participants

@richmidwinter

No description provided.

@ashward

Is there a misplaced parenthesis here? Should this not be: ... MD5Util().digest(xmppURI.getJID().toString()) +"?s=24&d=mm";

Also - just a thought: This would be simpler (and faster) if MD5Util.digest was a static method

@ashward

Do we need to guard against the same avatar being added multiple times?

@ashward ashward was assigned Jul 12, 2012
@richmidwinter richmidwinter merged commit 6857b69 into surevine:master Jul 13, 2012
@ashward

Just a thought - I sort of feels like we should be passing around the AvatarProvider itself rather than the AvatarProviderRegistry

If we're passing it around, I think I might agree unless there's going to be something else to do with avatars we'd want to pull off it. Really though I think we should be @Inject-ing the AvatarProviderRegistry where it needs to be accessed and not passing it around everywhere, I haven't been able to get that working though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment