From 671d3cf8f6a7cb2500dc701f633f601996e2b9e4 Mon Sep 17 00:00:00 2001 From: Miguel Serrano Date: Sun, 9 May 2021 18:11:28 +0200 Subject: [PATCH 1/3] Remove phx prefix from prop in ErrorTag --- lib/surface/components/form/error_tag.ex | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/surface/components/form/error_tag.ex b/lib/surface/components/form/error_tag.ex index d55c8a20..7fd43581 100644 --- a/lib/surface/components/form/error_tag.ex +++ b/lib/surface/components/form/error_tag.ex @@ -37,7 +37,7 @@ defmodule Surface.Components.Form.ErrorTag do ``` ```surface - + ``` ```surface @@ -97,7 +97,7 @@ defmodule Surface.Components.Form.ErrorTag do with an input of the same name. LiveView will exhibit buggy behavior without assigning separate id's to each.) """ - prop phx_feedback_for, :string + prop feedback_for, :string def render(assigns) do translate_error = assigns.translator || translator_from_config() || (&translate_error/1) @@ -108,7 +108,7 @@ defmodule Surface.Components.Form.ErrorTag do {translate_error.(error)} """ From b2eb11ea0d46d414818e0c342d10ad45bd614b3a Mon Sep 17 00:00:00 2001 From: Miguel Serrano Date: Sun, 9 May 2021 18:11:35 +0200 Subject: [PATCH 2/3] Fix tests --- test/components/form/error_tag_test.exs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/components/form/error_tag_test.exs b/test/components/form/error_tag_test.exs index 28c9c208..61d76a72 100644 --- a/test/components/form/error_tag_test.exs +++ b/test/components/form/error_tag_test.exs @@ -66,7 +66,7 @@ defmodule Surface.Components.Form.ErrorTagTest do refute html =~ "another test error" end - test "prop phx_feedback_for", %{changeset: changeset} do + test "prop feedback_for", %{changeset: changeset} do assigns = %{changeset: changeset} html = @@ -74,7 +74,7 @@ defmodule Surface.Components.Form.ErrorTagTest do ~H"""
- +
""" From daeeeaee5a816f27e346aad8a34d55b0ccbc19a7 Mon Sep 17 00:00:00 2001 From: Miguel Serrano Date: Sun, 9 May 2021 18:13:39 +0200 Subject: [PATCH 3/3] Update CHANGELOG --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3129b035..92335953 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # Changelog +## v0.5.0 (WIP) + + * [components] ErrorTag: Renamed prop `phx_trigger_action` to `trigger_action` + ## v0.4.0 (2021-05-01) * Call render when defined in slotable components (#283)