Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AoT compability #58

Merged
merged 1 commit into from
Jan 17, 2024
Merged

AoT compability #58

merged 1 commit into from
Jan 17, 2024

Conversation

Odonno
Copy link
Contributor

@Odonno Odonno commented Nov 29, 2023

  • Enable AoT compatible for SurrealDb libraries
  • Handle Source Generation for JSON (de)serialization
  • Update DI extensions to append/prepend Source Generated JSON Serializer
  • Create an ASP.NET API project that uses AoT & SurrealDb (Todo API)
  • Fix remaining compatibility issues
  • Create publish script and run it in CI/GitHub workflow (in another yaml file)
  • Compare benchmark performances (normal runtime vs. AoT)

Depends on multiple PRs including #48

Closes #56

Sources:

@Odonno Odonno force-pushed the chore/aot-compat branch 3 times, most recently from d789dee to 3e96320 Compare December 1, 2023 19:08
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

Attention: 197 lines in your changes are missing coverage. Please review.

Comparison is base (ad17e5c) 71.25% compared to head (ec91926) 69.54%.
Report is 1 commits behind head on main.

Files Patch % Lines
...b.Net/Internals/Json/SurrealDbSerializerOptions.cs 41.89% 42 Missing and 1 partial ⚠️
SurrealDb.Net/Internals/SurrealDbEngine.Ws.cs 71.71% 41 Missing and 2 partials ⚠️
...DependencyInjection/ServiceCollectionExtensions.cs 46.66% 32 Missing ⚠️
...rnals/Models/CurrentJsonSerializerOptionsForAot.cs 0.00% 24 Missing ⚠️
...ernals/Json/Converters/SurrealDbResultConverter.cs 73.80% 4 Missing and 7 partials ⚠️
SurrealDb.Net/Internals/SurrealDbEngine.Http.cs 92.64% 2 Missing and 8 partials ⚠️
...ls/Json/Converters/SurrealDbWsResponseConverter.cs 73.33% 3 Missing and 5 partials ⚠️
...urrealDb.Net/Models/Response/SurrealDbResult.Ok.cs 70.83% 4 Missing and 3 partials ⚠️
SurrealDb.Net/Models/Thing.From.Specific.cs 62.50% 3 Missing and 3 partials ⚠️
...rrealDb.Net/Internals/Ws/SurrealDbWsResponse.Ok.cs 72.22% 3 Missing and 2 partials ⚠️
... and 3 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   71.25%   69.54%   -1.72%     
==========================================
  Files         109      108       -1     
  Lines        3740     4150     +410     
  Branches      369      400      +31     
==========================================
+ Hits         2665     2886     +221     
- Misses        893     1059     +166     
- Partials      182      205      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Odonno Odonno force-pushed the chore/aot-compat branch 4 times, most recently from bd7c628 to ec91926 Compare December 9, 2023 11:12
@Odonno Odonno marked this pull request as ready for review December 9, 2023 11:29
@Odonno Odonno force-pushed the chore/aot-compat branch 2 times, most recently from f453112 to 33c861e Compare January 17, 2024 08:57
@kearfy kearfy merged commit cd4ac4d into surrealdb:main Jan 17, 2024
2 checks passed
@Odonno Odonno deleted the chore/aot-compat branch January 17, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AOT Strategy
3 participants