Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic navigation to next page - other option in dropdown shows error #2014

Closed
SamMousa opened this issue Mar 3, 2020 · 6 comments
Closed
Labels
Milestone

Comments

@SamMousa
Copy link
Contributor

@SamMousa SamMousa commented Mar 3, 2020

Are you requesting a feature, reporting a bug or asking a question?

Bug

What is the current behavior?

ezgif-5-210d12c2c814

What is the expected behavior?

SurveyJS should know that selecting other means we're not done yet; now the user is greeted with a big error that is very unexpected.

How would you reproduce the current behavior (if this is a bug)?

Enable automatically go to next page behavior create a question that has an other option.

Specify your

  • surveyjs platform (angular or react or jquery or knockout or vue): knockout
  • surveyjs version: *.12
@andrewtelnov andrewtelnov added the bug label Mar 3, 2020
@andrewtelnov

This comment has been minimized.

Copy link
Member

@andrewtelnov andrewtelnov commented Mar 3, 2020

@SamMousa What do you think? Should we disable the ability to go to next page if an end-user select other?

Thank you,
Andrew

@SamMousa

This comment has been minimized.

Copy link
Contributor Author

@SamMousa SamMousa commented Mar 3, 2020

I think this should be done more abstract, this way we can support custom question types as well.

What about validating the question silently and only attempting navigation if it succeeds?

@SamMousa

This comment has been minimized.

Copy link
Contributor Author

@SamMousa SamMousa commented Mar 3, 2020

Silently meaning don't show markup for failed or successful validation

@SamMousa

This comment has been minimized.

Copy link
Contributor Author

@SamMousa SamMousa commented Mar 3, 2020

I guess the core library could offer this via events, so that a question can fire something when it is complete?

@andrewtelnov

This comment has been minimized.

Copy link
Member

@andrewtelnov andrewtelnov commented Mar 3, 2020

@SamMousa We have public supportGoNextPageAutomatic(); that some questions overrides, it returns false by default. We check for errors silently as well, probably there is a bug, I have to check.
Here is the link to the code.
Here is my question:
Should we disable this functionality for radio group/dropdown when the other is choosen or go to the next page, when the other/comment field is filled? What do you think?

Thank you,
Andrew

@andrewtelnov andrewtelnov changed the title Automatic navigation to next page - other option Automatic navigation to next page - other option in dropdown shows error Mar 3, 2020
@andrewtelnov andrewtelnov added this to the v1.5.13 milestone Mar 3, 2020
andrewtelnov added a commit that referenced this issue Mar 3, 2020
@andrewtelnov

This comment has been minimized.

Copy link
Member

@andrewtelnov andrewtelnov commented Mar 3, 2020

@SamMousa I decided to go to the next page on setting value to other comment. The issue is fixed. The fix will be available in the next minor update that we will relese on this week.

Thank you,
Andrew

@andrewtelnov andrewtelnov added the fixed label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.