New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallels fix: when there's no title, display acronym, don't repeat in nerdy row #152

Merged
merged 2 commits into from Nov 8, 2017

Conversation

Projects
None yet
2 participants
@TrebuhD
Copy link
Contributor

TrebuhD commented Nov 8, 2017

No description provided.

@TrebuhD TrebuhD requested a review from gradam Nov 8, 2017

@@ -211,7 +213,8 @@
// returns the relevant header, either the title in the translated language,
// otherwise in pali or otherwise just the ID.
_computeTitle() {
return this.parallelItem.original_title ? this.parallelItem.original_title : this.parallelItem.uid;
return this.parallelItem.original_title ? this.parallelItem.original_title :
this.parallelItem.acronym ? this.parallelItem.acronym : this.parallelItem.uid;

This comment has been minimized.

@gradam

gradam Nov 8, 2017

Contributor

I am still not sure if nested inline ifs is a good idea

@gradam

gradam approved these changes Nov 8, 2017

@gradam gradam merged commit 32e549f into development Nov 8, 2017

1 check passed

continuous-integration/travis-ci/push The Travis CI build passed
Details

@gradam gradam deleted the parallels-id-title-fix branch Nov 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment