From 66c97fc83651895c559418944af035a9deae334b Mon Sep 17 00:00:00 2001 From: Suwei Chen Date: Tue, 11 Jul 2017 17:14:22 -0700 Subject: [PATCH] OS12507864: Correct assertion introduced in PR#3211 The assertions are intended to future-proof the assumption that isInlineSegment being true implies segment swap. https://github.com/Microsoft/ChakraCore/pull/3211 --- lib/Runtime/Library/JavascriptArray.inl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Runtime/Library/JavascriptArray.inl b/lib/Runtime/Library/JavascriptArray.inl index c25790f54b2..f3ca0febbea 100644 --- a/lib/Runtime/Library/JavascriptArray.inl +++ b/lib/Runtime/Library/JavascriptArray.inl @@ -866,7 +866,7 @@ SECOND_PASS: } startSeg = current; - Assert(startSeg == oldStartSeg || isInlineSegment); + Assert(startSeg != oldStartSeg || !isInlineSegment); // ensure isInlineSegment implies startSeg != oldStartSeg if (isInlineSegment) { this->ClearElements(oldStartSeg, 0); @@ -955,7 +955,7 @@ SECOND_PASS: } } - Assert(oldCurrent == current || isInlineSegment); + Assert(oldCurrent != current || !isInlineSegment); // ensure isInlineSegment implies oldCurrent != current if (isInlineSegment) { this->ClearElements(oldCurrent, 0);